Apply review comments

BrunoQuaresma · BrunoQuaresma · commit 38a8d6227053 · 2025-05-14T16:25:39.000Z
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -225,7 +225,7 @@ export const watchWorkspaceAgentLogs = (
 ) => {
 	const searchParams = new URLSearchParams({
 		follow: "true",
-		after: params?.after ? params?.after.toString() : "",
+		after: params?.after?.toString() ?? "",
 	});
 
 	/**
diff --git a/site/src/modules/resources/useAgentLogs.ts b/site/src/modules/resources/useAgentLogs.ts
@@ -6,14 +6,14 @@ import { useEffect, useState } from "react";
 export function useAgentLogs(
 	agent: WorkspaceAgent,
 	enabled: boolean,
-): readonly WorkspaceAgentLog[] | undefined {
-	const [logs, setLogs] = useState<WorkspaceAgentLog[]>();
+): readonly WorkspaceAgentLog[] {
+	const [logs, setLogs] = useState<WorkspaceAgentLog[]>([]);
 
 	useEffect(() => {
 		if (!enabled) {
 			// Clean up the logs when the agent is not enabled. So it can receive logs
 			// from the beginning without duplicating the logs.
-			setLogs(undefined);
+			setLogs([]);
 			return;
 		}
 
@@ -26,9 +26,7 @@ export function useAgentLogs(
 				console.warn("Error parsing agent log: ", e.parseError);
 				return;
 			}
-			setLogs((logs) =>
-				logs ? [...logs, ...e.parsedMessage] : [...e.parsedMessage],
-			);
+			setLogs((logs) => [...logs, ...e.parsedMessage]);
 		});
 
 		socket.addEventListener("error", (e) => {
diff --git a/site/src/pages/WorkspacePage/WorkspacePage.test.tsx b/site/src/pages/WorkspacePage/WorkspacePage.test.tsx
@@ -51,12 +51,7 @@ const renderWorkspacePage = async (
 	jest
 		.spyOn(API, "getDeploymentConfig")
 		.mockResolvedValueOnce(MockDeploymentConfig);
-	jest.spyOn(apiModule, "watchWorkspaceAgentLogs").mockImplementation(
-		() =>
-			new OneWayWebSocket({
-				apiRoute: "",
-			}),
-	);
+	jest.spyOn(apiModule, "watchWorkspaceAgentLogs");
 
 	renderWithAuth(<WorkspacePage />, {
 		...options,
