chore: finish tests

Parkreiner · Parkreiner · commit 38ba3b2ca3d9 · 2023-11-01T15:46:51.000Z
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx
@@ -20,6 +20,7 @@ import {
   waitForLoaderToBeRemoved,
 } from "testHelpers/renderHelpers";
 import CreateWorkspacePage from "./CreateWorkspacePage";
+import { Language } from "./CreateWorkspacePageView";
 
 const nameLabelText = "Workspace Name";
 const createWorkspaceText = "Create Workspace";
@@ -270,4 +271,25 @@ describe("CreateWorkspacePage", () => {
       );
     });
   });
+
+  it("Detects when a workspace is being created with the 'duplicate' mode", async () => {
+    const params = new URLSearchParams({
+      mode: "duplicate",
+      name: MockWorkspace.name,
+      version: MockWorkspace.template_active_version_id,
+    });
+
+    renderWithAuth(<CreateWorkspacePage />, {
+      path: "/templates/:template/workspace",
+      route: `/templates/${MockWorkspace.name}/workspace?${params.toString()}`,
+    });
+
+    const warningMessage = await screen.findByRole("alert");
+    const nameInput = await screen.findByRole("textbox", {
+      name: "Workspace Name",
+    });
+
+    expect(warningMessage).toHaveTextContent(Language.duplicationWarning);
+    expect(nameInput).toHaveValue(`${MockWorkspace.name}-copy`);
+  });
 });
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
@@ -37,6 +37,11 @@ import { useSearchParams } from "react-router-dom";
 import { CreateWSPermissions } from "./permissions";
 import { Alert } from "components/Alert/Alert";
 
+export const Language = {
+  duplicationWarning:
+    "Duplicating a workspace only copies its parameters. No state from the old workspace is copied over.",
+} as const;
+
 export interface CreateWorkspacePageViewProps {
   mode: CreateWorkspaceMode;
   error: unknown;
@@ -124,8 +129,7 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
 
         {mode === "duplicate" && (
           <Alert severity="info" dismissible>
-            Duplicating a workspace only copies its parameters. No state from
-            the old workspace is copied over.
+            {Language.duplicationWarning}
           </Alert>
         )}
 
diff --git a/site/src/pages/CreateWorkspacePage/useWorkspaceDuplication.test.tsx b/site/src/pages/CreateWorkspacePage/useWorkspaceDuplication.test.tsx
@@ -90,8 +90,9 @@ describe(`${useWorkspaceDuplication.name}`, () => {
       M.MockWorkspaceBuildParameter5,
     ];
 
-    for (const p of mockBuildParams) {
-      expect(parsedParams.get(`param.${p.name}`)).toEqual(p.value);
+    for (const { name, value } of mockBuildParams) {
+      const key = `param.${name}`;
+      expect(parsedParams.get(key)).toEqual(value);
     }
   });
 
@@ -101,13 +102,13 @@ describe(`${useWorkspaceDuplication.name}`, () => {
     await performNavigation(button, router);
 
     const parsedParams = new URLSearchParams(router.state.location.search);
-    const expectedParamEntries = [
+    const extraMetadataEntries = [
       ["mode", "duplicate"],
       ["name", MockWorkspace.name],
       ["version", MockWorkspace.template_active_version_id],
     ] as const;
 
-    for (const [key, value] of expectedParamEntries) {
+    for (const [key, value] of extraMetadataEntries) {
       expect(parsedParams.get(key)).toBe(value);
     }
   });
