Fix component render bug

ammario · ammario · commit 390e3c959ca2 · 2023-03-23T21:37:04.000Z
diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
@@ -53,11 +53,14 @@ const MetadataItem: FC<{ item: WorkspaceAgentMetadata }> = ({ item }) => {
 }
 
 export interface AgentMetadataViewProps {
-  metadata: WorkspaceAgentMetadata[]
+  metadata?: WorkspaceAgentMetadata[]
 }
 
 export const AgentMetadataView: FC<AgentMetadataViewProps> = ({ metadata }) => {
   const styles = useStyles()
+  if (metadata === undefined) {
+    return <CircularProgress size={16} />
+  }
   if (metadata.length === 0) {
     return <></>
   }
@@ -99,10 +102,6 @@ export const AgentMetadata: FC<{
     }
   }, [agent.id, watchAgentMetadata])
 
-  if (metadata === undefined) {
-    return <CircularProgress size={16} />
-  }
-
   return AgentMetadataView({ metadata })
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,11 +53,14 @@ const MetadataItem: FC<{ item: WorkspaceAgentMetadata }> = ({ item }) => {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`export interface AgentMetadataViewProps {`
`56`		`- metadata: WorkspaceAgentMetadata[]`
	`56`	`+ metadata?: WorkspaceAgentMetadata[]`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`export const AgentMetadataView: FC<AgentMetadataViewProps> = ({ metadata }) => {`
`60`	`60`	`const styles = useStyles()`
	`61`	`+ if (metadata === undefined) {`
	`62`	`+ return <CircularProgress size={16} />`
	`63`	`+ }`
`61`	`64`	`if (metadata.length === 0) {`
`62`	`65`	`return <></>`
`63`	`66`	`}`
`@@ -99,10 +102,6 @@ export const AgentMetadata: FC<{`
`99`	`102`	`}`
`100`	`103`	`}, [agent.id, watchAgentMetadata])`
`101`	`104`
`102`		`- if (metadata === undefined) {`
`103`		`- return <CircularProgress size={16} />`
`104`		`- }`
`105`		`-`
`106`	`105`	`return AgentMetadataView({ metadata })`
`107`	`106`	`}`
`108`	`107`