add fixmes to dbauthz

mafredri · mafredri · commit 397cc7ab088c · 2023-07-21T09:35:23.000Z
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -1174,13 +1174,15 @@ func (q *querier) GetTemplateDAUs(ctx context.Context, arg database.GetTemplateD
 }
 
 func (q *querier) GetTemplateDailyInsights(ctx context.Context, arg database.GetTemplateDailyInsightsParams) ([]database.GetTemplateDailyInsightsRow, error) {
+	// FIXME: this should maybe be READ rbac.ResourceTemplate or it's own resource.
 	if err := q.authorizeContext(ctx, rbac.ActionRead, rbac.ResourceSystem); err != nil {
 		return nil, err
 	}
 	return q.db.GetTemplateDailyInsights(ctx, arg)
 }
 
 func (q *querier) GetTemplateInsights(ctx context.Context, arg database.GetTemplateInsightsParams) (database.GetTemplateInsightsRow, error) {
+	// FIXME: this should maybe be READ rbac.ResourceTemplate or it's own resource.
 	if err := q.authorizeContext(ctx, rbac.ActionRead, rbac.ResourceSystem); err != nil {
 		return database.GetTemplateInsightsRow{}, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -1174,13 +1174,15 @@ func (q *querier) GetTemplateDAUs(ctx context.Context, arg database.GetTemplateD`
`1174`	`1174`	`}`
`1175`	`1175`
`1176`	`1176`	`func (q *querier) GetTemplateDailyInsights(ctx context.Context, arg database.GetTemplateDailyInsightsParams) ([]database.GetTemplateDailyInsightsRow, error) {`
	`1177`	`+ // FIXME: this should maybe be READ rbac.ResourceTemplate or it's own resource.`
`1177`	`1178`	`if err := q.authorizeContext(ctx, rbac.ActionRead, rbac.ResourceSystem); err != nil {`
`1178`	`1179`	`return nil, err`
`1179`	`1180`	`}`
`1180`	`1181`	`return q.db.GetTemplateDailyInsights(ctx, arg)`
`1181`	`1182`	`}`
`1182`	`1183`
`1183`	`1184`	`func (q *querier) GetTemplateInsights(ctx context.Context, arg database.GetTemplateInsightsParams) (database.GetTemplateInsightsRow, error) {`
	`1185`	`+ // FIXME: this should maybe be READ rbac.ResourceTemplate or it's own resource.`
`1184`	`1186`	`if err := q.authorizeContext(ctx, rbac.ActionRead, rbac.ResourceSystem); err != nil {`
`1185`	`1187`	`return database.GetTemplateInsightsRow{}, err`
`1186`	`1188`	`}`