cleanup

ethanndickson · ethanndickson · commit 3a4b3358f4e2 · 2024-11-15T04:25:52.000Z
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -929,7 +929,9 @@ jobs:
         with:
           name: dylibs
           path: ./build
-      - run: |
+
+      - name: Insert dylibs
+        run: |
           mv ./build/*amd64.dylib ./site/out/bin/coder-amd64.dylib
           mv ./build/*arm64.dylib ./site/out/bin/coder-arm64.dylib
           mv ./build/*.h          ./site/out/bin/coder-dylib.h
diff --git a/vpn/dylib/lib.go b/vpn/dylib/lib.go
@@ -57,9 +57,12 @@ func (f *pipeConn) Write(p []byte) (n int, err error) {
 }
 
 func (f *pipeConn) Close() error {
-	_ = f.r.Close()
-	_ = f.w.Close()
-	return nil
+	rErr := f.r.Close()
+	wErr := f.w.Close()
+	if rErr != nil {
+		return rErr
+	}
+	return wErr
 }
 
 func newFdConn(cReadFD, cWriteFD int32) (io.ReadWriteCloser, error) {

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,12 @@ func (f *pipeConn) Write(p []byte) (n int, err error) {`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`func (f *pipeConn) Close() error {`
`60`		`- _ = f.r.Close()`
`61`		`- _ = f.w.Close()`
`62`		`- return nil`
	`60`	`+ rErr := f.r.Close()`
	`61`	`+ wErr := f.w.Close()`
	`62`	`+ if rErr != nil {`
	`63`	`+ return rErr`
	`64`	`+ }`
	`65`	`+ return wErr`
`63`	`66`	`}`
`64`	`67`
`65`	`68`	`func newFdConn(cReadFD, cWriteFD int32) (io.ReadWriteCloser, error) {`