Fix infinite loop in useEffect

bryphe-coder · bryphe-coder · commit 3b02d211042b · 2022-02-23T03:53:00.000Z
diff --git a/site/contexts/UserContext.tsx b/site/contexts/UserContext.tsx
@@ -39,7 +39,10 @@ export const useUser = (redirectOnError = false): UserContext => {
         },
       })
     }
-  }, [asPath, push, redirectOnError, requestError])
+    // Disabling exhaustive deps here because it can cause an
+    // infinite useEffect loop. Should (hopefully) go away
+    // when we switch to an alternate routing strategy.
+  }, [redirectOnError, requestError]) // eslint-disable-line react-hooks/exhaustive-deps
 
   return ctx
 }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,10 @@ export const useUser = (redirectOnError = false): UserContext => {`
`39`	`39`	`},`
`40`	`40`	`})`
`41`	`41`	`}`
`42`		`- }, [asPath, push, redirectOnError, requestError])`
	`42`	`+ // Disabling exhaustive deps here because it can cause an`
	`43`	`+ // infinite useEffect loop. Should (hopefully) go away`
	`44`	`+ // when we switch to an alternate routing strategy.`
	`45`	`+ }, [redirectOnError, requestError]) // eslint-disable-line react-hooks/exhaustive-deps`
`43`	`46`
`44`	`47`	`return ctx`
`45`	`48`	`}`