added description validation and tests

Kira-Pilot · Kira-Pilot · commit 3bab482a58a3 · 2022-08-24T14:38:27.000Z
diff --git a/site/src/pages/TemplateSettingsPage/TemplateSettingsForm.tsx b/site/src/pages/TemplateSettingsPage/TemplateSettingsForm.tsx
@@ -23,12 +23,19 @@ export const Language = {
   formAriaLabel: "Template settings form",
   selectEmoji: "Select emoji",
   ttlMaxError: "Please enter a limit that is less than or equal to 168 hours (7 days).",
+  descriptionMaxError: "Please enter a description that is less than or equal to 128 characters.",
 }
 
+const MAX_DESCRIPTION_CHAR_LIMIT = 128
+const MAX_TTL_DAYS = 7
+
 export const validationSchema = Yup.object({
   name: nameValidator(Language.nameLabel),
-  description: Yup.string(),
-  max_ttl_ms: Yup.number().integer().min(0).max(168, Language.ttlMaxError),
+  description: Yup.string().max(MAX_DESCRIPTION_CHAR_LIMIT, Language.descriptionMaxError),
+  max_ttl_ms: Yup.number()
+    .integer()
+    .min(0)
+    .max(24 * MAX_TTL_DAYS /* 7 days in hours */, Language.ttlMaxError),
 })
 
 export interface TemplateSettingsForm {
diff --git a/site/src/pages/TemplateSettingsPage/TemplateSettingsPage.test.tsx b/site/src/pages/TemplateSettingsPage/TemplateSettingsPage.test.tsx
@@ -111,4 +111,24 @@ describe("TemplateSettingsPage", () => {
     const validate = () => validationSchema.validateSync(values)
     expect(validate).toThrowError(FormLanguage.ttlMaxError)
   })
+
+  it("allows a description of 128 chars", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      description:
+        "Nam quis nulla. Integer malesuada. In in enim a arcu imperdiet malesuada. Sed vel lectus. Donec odio urna, tempus molestie, port",
+    }
+    const validate = () => validationSchema.validateSync(values)
+    expect(validate).not.toThrowError()
+  })
+
+  it("disallows a description of 128 + 1 chars", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      description:
+        "Nam quis nulla. Integer malesuada. In in enim a arcu imperdiet malesuada. Sed vel lectus. Donec odio urna, tempus molestie, port a",
+    }
+    const validate = () => validationSchema.validateSync(values)
+    expect(validate).toThrowError(FormLanguage.descriptionMaxError)
+  })
 })
