Cleanup

Emyrk · Emyrk · commit 3bff48e9f4c8 · 2022-05-25T16:15:02.000-05:00
diff --git a/coderd/parameters.go b/coderd/parameters.go
@@ -84,8 +84,7 @@ func (api *api) parameters(rw http.ResponseWriter, r *http.Request) {
 	if !ok {
 		return
 	}
-	// Should we allow reading the params of the resource if they can read the
-	// resource? Will this leak secrets?
+
 	if !api.Authorize(rw, r, rbac.ActionRead, obj) {
 		return
 	}
diff --git a/codersdk/organizations.go b/codersdk/organizations.go
@@ -92,7 +92,7 @@ func (c *Client) Organization(ctx context.Context, id uuid.UUID) (Organization,
 // ProvisionerDaemonsByOrganization returns provisioner daemons available for an organization.
 func (c *Client) ProvisionerDaemons(ctx context.Context) ([]ProvisionerDaemon, error) {
 	res, err := c.Request(ctx, http.MethodGet,
-		fmt.Sprintf("/api/v2/provisionerdaemons"),
+		"/api/v2/provisionerdaemons",
 		nil,
 	)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,7 @@ func (api api) parameters(rw http.ResponseWriter, r http.Request) {`
`84`	`84`	`if !ok {`
`85`	`85`	`return`
`86`	`86`	`}`
`87`		`- // Should we allow reading the params of the resource if they can read the`
`88`		`- // resource? Will this leak secrets?`
	`87`	`+`
`89`	`88`	`if !api.Authorize(rw, r, rbac.ActionRead, obj) {`
`90`	`89`	`return`
`91`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ func (c *Client) Organization(ctx context.Context, id uuid.UUID) (Organization,`
`92`	`92`	`// ProvisionerDaemonsByOrganization returns provisioner daemons available for an organization.`
`93`	`93`	`func (c *Client) ProvisionerDaemons(ctx context.Context) ([]ProvisionerDaemon, error) {`
`94`	`94`	`res, err := c.Request(ctx, http.MethodGet,`
`95`		`- fmt.Sprintf("/api/v2/provisionerdaemons"),`
	`95`	`+ "/api/v2/provisionerdaemons",`
`96`	`96`	`nil,`
`97`	`97`	`)`
`98`	`98`	`if err != nil {`