fix bug in marking container as dirty

mafredri · mafredri · commit 3cd9cc1a89fd · 2025-05-21T16:12:08.000Z
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -677,9 +677,15 @@ func (api *API) markDevcontainerDirty(configPath string, modifiedAt time.Time) {
 				slog.F("modified_at", modifiedAt),
 			)
 			api.knownDevcontainers[i].Dirty = true
-			if api.knownDevcontainers[i].Container != nil {
-				api.knownDevcontainers[i].Container.DevcontainerDirty = true
-			}
+		}
+		if api.knownDevcontainers[i].Container != nil && !api.knownDevcontainers[i].Container.DevcontainerDirty {
+			api.logger.Info(api.ctx, "marking devcontainer container as dirty",
+				slog.F("file", configPath),
+				slog.F("name", api.knownDevcontainers[i].Name),
+				slog.F("workspace_folder", api.knownDevcontainers[i].WorkspaceFolder),
+				slog.F("modified_at", modifiedAt),
+			)
+			api.knownDevcontainers[i].Container.DevcontainerDirty = true
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -677,9 +677,15 @@ func (api *API) markDevcontainerDirty(configPath string, modifiedAt time.Time) {`
`677`	`677`	`slog.F("modified_at", modifiedAt),`
`678`	`678`	`)`
`679`	`679`	`api.knownDevcontainers[i].Dirty = true`
`680`		`- if api.knownDevcontainers[i].Container != nil {`
`681`		`- api.knownDevcontainers[i].Container.DevcontainerDirty = true`
`682`		`- }`
	`680`	`+ }`
	`681`	`+ if api.knownDevcontainers[i].Container != nil && !api.knownDevcontainers[i].Container.DevcontainerDirty {`
	`682`	`+ api.logger.Info(api.ctx, "marking devcontainer container as dirty",`
	`683`	`+ slog.F("file", configPath),`
	`684`	`+ slog.F("name", api.knownDevcontainers[i].Name),`
	`685`	`+ slog.F("workspace_folder", api.knownDevcontainers[i].WorkspaceFolder),`
	`686`	`+ slog.F("modified_at", modifiedAt),`
	`687`	`+ )`
	`688`	`+ api.knownDevcontainers[i].Container.DevcontainerDirty = true`
`683`	`689`	`}`
`684`	`690`	`}`
`685`	`691`	`}`