green????

aslilac · aslilac · commit 3d507dd1e319 · 2024-08-14T22:11:05.000Z
diff --git a/site/src/hooks/useEmbeddedMetadata.ts b/site/src/hooks/useEmbeddedMetadata.ts
@@ -223,6 +223,7 @@ export function makeUseEmbeddedMetadata(
       manager.getMetadata,
     );
 
+    // biome-ignore lint/correctness/useExhaustiveDependencies(manager.clearMetadataByKey): baked into containing hook
     const stableMetadataResult = useMemo<UseEmbeddedMetadataResult>(() => {
       return {
         metadata,
diff --git a/site/src/modules/dashboard/DeploymentBanner/DeploymentBannerView.tsx b/site/src/modules/dashboard/DeploymentBanner/DeploymentBannerView.tsx
@@ -98,8 +98,7 @@ export const DeploymentBannerView: FC<DeploymentBannerViewProps> = ({
       return "just now";
     }
     return dayjs().to(dayjs(stats.collected_at));
-    // eslint-disable-next-line react-hooks/exhaustive-deps -- We want this to periodically update!
-  }, [timeUntilRefresh, stats]);
+  }, [stats, fetchStats]);
 
   const healthErrors = health ? getHealthErrors(health) : [];
   const displayLatency = stats?.workspaces.connection_latency_ms.P50 || -1;
diff --git a/site/src/modules/resources/AgentMetadata.tsx b/site/src/modules/resources/AgentMetadata.tsx
@@ -181,6 +181,7 @@ const StaticWidth: FC<HTMLAttributes<HTMLDivElement>> = ({
 }) => {
   const ref = useRef<HTMLDivElement>(null);
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useLayoutEffect(() => {
     // Ignore this in storybook
     if (!ref.current || process.env.STORYBOOK === "true") {
diff --git a/site/src/modules/resources/AgentRow.tsx b/site/src/modules/resources/AgentRow.tsx
@@ -121,37 +121,35 @@ export const AgentRow: FC<AgentRowProps> = ({
   }, [agent.lifecycle_state, hasStartupFeatures]);
 
   // This is a layout effect to remove flicker when we're scrolling to the bottom.
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useLayoutEffect(() => {
     // If we're currently watching the bottom, we always want to stay at the bottom.
     if (bottomOfLogs && logListRef.current) {
       logListRef.current.scrollToItem(startupLogs.length - 1, "end");
     }
-  }, [showLogs, startupLogs, logListRef, bottomOfLogs]);
+  }, [showLogs, startupLogs, bottomOfLogs]);
 
   // This is a bit of a hack on the react-window API to get the scroll position.
   // If we're scrolled to the bottom, we want to keep the list scrolled to the bottom.
   // This makes it feel similar to a terminal that auto-scrolls downwards!
-  const handleLogScroll = useCallback(
-    (props: ListOnScrollProps) => {
-      if (
-        props.scrollOffset === 0 ||
-        props.scrollUpdateWasRequested ||
-        !logListDivRef.current
-      ) {
-        return;
-      }
-      // The parent holds the height of the list!
-      const parent = logListDivRef.current.parentElement;
-      if (!parent) {
-        return;
-      }
-      const distanceFromBottom =
-        logListDivRef.current.scrollHeight -
-        (props.scrollOffset + parent.clientHeight);
-      setBottomOfLogs(distanceFromBottom < AGENT_LOG_LINE_HEIGHT);
-    },
-    [logListDivRef],
-  );
+  const handleLogScroll = useCallback((props: ListOnScrollProps) => {
+    if (
+      props.scrollOffset === 0 ||
+      props.scrollUpdateWasRequested ||
+      !logListDivRef.current
+    ) {
+      return;
+    }
+    // The parent holds the height of the list!
+    const parent = logListDivRef.current.parentElement;
+    if (!parent) {
+      return;
+    }
+    const distanceFromBottom =
+      logListDivRef.current.scrollHeight -
+      (props.scrollOffset + parent.clientHeight);
+    setBottomOfLogs(distanceFromBottom < AGENT_LOG_LINE_HEIGHT);
+  }, []);
 
   return (
     <Stack
diff --git a/site/src/modules/templates/useWatchVersionLogs.ts b/site/src/modules/templates/useWatchVersionLogs.ts
@@ -10,6 +10,7 @@ export const useWatchVersionLogs = (
   const templateVersionId = templateVersion?.id;
   const templateVersionStatus = templateVersion?.job.status;
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useEffect(() => {
     setLogs(undefined);
   }, [templateVersionId]);
diff --git a/site/src/pages/CreateTemplatePage/BuildLogsDrawer.tsx b/site/src/pages/CreateTemplatePage/BuildLogsDrawer.tsx
@@ -38,10 +38,12 @@ export const BuildLogsDrawer: FC<BuildLogsDrawerProps> = ({
     }, 0);
   };
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useLayoutEffect(() => {
     scrollToBottom();
   }, [logs]);
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useLayoutEffect(() => {
     if (drawerProps.open) {
       scrollToBottom();
diff --git a/site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPageView.tsx b/site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPageView.tsx
@@ -24,6 +24,7 @@ export const TemplateSummaryPageView: FC<TemplateSummaryPageViewProps> = ({
   const navigate = useNavigate();
   const location = useLocation();
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useEffect(() => {
     if (location.hash === "#readme") {
       // We moved the readme to the docs page, but we known that some users
diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx
@@ -178,6 +178,7 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
 
   // Auto scroll
   const logsContentRef = useRef<HTMLDivElement>(null);
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useEffect(() => {
     if (logsContentRef.current) {
       logsContentRef.current.scrollTop = logsContentRef.current.scrollHeight;
diff --git a/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx b/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx
@@ -77,6 +77,7 @@ export const WorkspaceBuildProgress: FC<WorkspaceBuildProgressProps> = ({
   // By default workspace is updated every second, which can cause visual stutter
   // when the build estimate is a few seconds. The timer ensures no observable
   // stutter in all cases.
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useEffect(() => {
     const updateProgress = () => {
       if (
diff --git a/site/src/pages/WorkspacePage/WorkspaceNotifications/WorkspaceNotifications.tsx b/site/src/pages/WorkspacePage/WorkspaceNotifications/WorkspaceNotifications.tsx
@@ -153,6 +153,7 @@ export const WorkspaceNotifications: FC<WorkspaceNotificationsProps> = ({
   // figure out if this effect really should run every render (possibly meaning
   // no dependency array at all), or how to get the array stabilized (ideal)
   const now = dayjs();
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useEffect(() => {
     if (
       workspace.latest_build.status !== "pending" ||
diff --git a/site/src/pages/WorkspacesPage/BatchUpdateConfirmation.tsx b/site/src/pages/WorkspacesPage/BatchUpdateConfirmation.tsx
@@ -77,6 +77,7 @@ export const BatchUpdateConfirmation: FC<BatchUpdateConfirmationProps> = ({
   const [stage, setStage] = useState<
     "consequences" | "dormantWorkspaces" | "updates" | null
   >(null);
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useEffect(() => {
     if (runningWorkspacesToUpdate.length > 0) {
       setStage("consequences");
diff --git a/site/src/pages/WorkspacesPage/WorkspacesPage.tsx b/site/src/pages/WorkspacesPage/WorkspacesPage.tsx
@@ -72,6 +72,7 @@ const WorkspacesPage: FC = () => {
 
   // We want to uncheck the selected workspaces always when the url changes
   // because of filtering or pagination
+  // biome-ignore lint/correctness/useExhaustiveDependencies: consider refactoring
   useEffect(() => {
     setCheckedWorkspaces([]);
   }, [urlSearchParams]);

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,7 @@ export const DeploymentBannerView: FC<DeploymentBannerViewProps> = ({`
`98`	`98`	`return "just now";`
`99`	`99`	`}`
`100`	`100`	`return dayjs().to(dayjs(stats.collected_at));`
`101`		`- // eslint-disable-next-line react-hooks/exhaustive-deps -- We want this to periodically update!`
`102`		`- }, [timeUntilRefresh, stats]);`
	`101`	`+ }, [stats, fetchStats]);`
`103`	`102`
`104`	`103`	`const healthErrors = health ? getHealthErrors(health) : [];`
`105`	`104`	`const displayLatency = stats?.workspaces.connection_latency_ms.P50 \|\| -1;`