fix(site): show error when renaming template to existing template

ethanndickson · ethanndickson · commit 3e07a6c951c7 · 2024-11-04T05:47:55.000Z
diff --git a/coderd/templates.go b/coderd/templates.go
@@ -841,7 +841,17 @@ func (api *API) patchTemplateMeta(rw http.ResponseWriter, r *http.Request) {
 		return nil
 	}, nil)
 	if err != nil {
-		httpapi.InternalServerError(rw, err)
+		if database.IsUniqueViolation(err) {
+			httpapi.Write(ctx, rw, http.StatusConflict, codersdk.Response{
+				Message: fmt.Sprintf("Template %q already exists.", req.Name),
+				Validations: []codersdk.ValidationError{{
+					Field:  "name",
+					Detail: "This value is already in use and should be unique.",
+				}},
+			})
+		} else {
+			httpapi.InternalServerError(rw, err)
+		}
 		return
 	}
 
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx
@@ -1,7 +1,7 @@
 import { API } from "api/api";
 import { templateByNameKey } from "api/queries/templates";
 import type { UpdateTemplateMeta } from "api/typesGenerated";
-import { displaySuccess } from "components/GlobalSnackbar/utils";
+import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
 import { useDashboard } from "modules/dashboard/useDashboard";
 import { linkToTemplate, useLinks } from "modules/navigation";
 import type { FC } from "react";
@@ -11,6 +11,7 @@ import { useNavigate, useParams } from "react-router-dom";
 import { pageTitle } from "utils/page";
 import { useTemplateSettings } from "../TemplateSettingsLayout";
 import { TemplateSettingsPageView } from "./TemplateSettingsPageView";
+import { getErrorMessage } from "api/errors";
 
 export const TemplateSettingsPage: FC = () => {
 	const { template: templateName } = useParams() as { template: string };
@@ -51,6 +52,9 @@ export const TemplateSettingsPage: FC = () => {
 				displaySuccess("Template updated successfully");
 				navigate(getLink(linkToTemplate(data.organization_name, data.name)));
 			},
+			onError: (error) => {
+				displayError(getErrorMessage(error, "Failed to update template"));
+			},
 		},
 	);
 
