Modify 404 message

Emyrk · Emyrk · commit 3f077382db64 · 2022-06-10T16:02:09.000-05:00
diff --git a/coderd/httpapi/httpapi.go b/coderd/httpapi/httpapi.go
@@ -80,7 +80,7 @@ type Error struct {
 // to prevent leaking existence of resources.
 func ResourceNotFound(rw http.ResponseWriter) {
 	Write(rw, http.StatusNotFound, Response{
-		Message: "Resource not found",
+		Message: "Resource not found or you do not have access to this resource",
 	})
 }
 
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -659,7 +659,7 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {
 		require.IsType(t, err, &codersdk.Error{}, "expected codersdk.Error")
 		coderSDKErr, _ := err.(*codersdk.Error) //nolint:errorlint
 		require.Equal(t, coderSDKErr.StatusCode(), 404, "expected status code 404")
-		require.Equal(t, "Resource not found", coderSDKErr.Message, "unexpected response code")
+		require.Contains(t, coderSDKErr.Message, "Resource not found", "unexpected response code")
 	})
 }
 
@@ -774,7 +774,7 @@ func TestWorkspaceUpdateTTL(t *testing.T) {
 		require.IsType(t, err, &codersdk.Error{}, "expected codersdk.Error")
 		coderSDKErr, _ := err.(*codersdk.Error) //nolint:errorlint
 		require.Equal(t, coderSDKErr.StatusCode(), 404, "expected status code 404")
-		require.Equal(t, "Resource not found", coderSDKErr.Message, "unexpected response code")
+		require.Contains(t, coderSDKErr.Message, "Resource not found", "unexpected response code")
 	})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ type Error struct {`
`80`	`80`	`// to prevent leaking existence of resources.`
`81`	`81`	`func ResourceNotFound(rw http.ResponseWriter) {`
`82`	`82`	`Write(rw, http.StatusNotFound, Response{`
`83`		`- Message: "Resource not found",`
	`83`	`+ Message: "Resource not found or you do not have access to this resource",`
`84`	`84`	`})`
`85`	`85`	`}`
`86`	`86`