add todo

mafredri · mafredri · commit 402ee07dfbb6 · 2023-12-15T12:27:32.000Z
diff --git a/cli/open.go b/cli/open.go
@@ -117,6 +117,7 @@ func (r *RootCmd) openVSCode() *clibase.Cmd {
 					return xerrors.Errorf("directory path %q not supported, use an absolute path instead", directory)
 				}
 				if insideThisWorkspace {
+					// TODO(mafredri): Return error if directory doesn't exist?
 					directory, err = filepath.Abs(directory)
 					if err != nil {
 						return xerrors.Errorf("expand directory: %w", err)

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ func (r RootCmd) openVSCode() clibase.Cmd {`
`117`	`117`	`return xerrors.Errorf("directory path %q not supported, use an absolute path instead", directory)`
`118`	`118`	`}`
`119`	`119`	`if insideThisWorkspace {`
	`120`	`+ // TODO(mafredri): Return error if directory doesn't exist?`
`120`	`121`	`directory, err = filepath.Abs(directory)`
`121`	`122`	`if err != nil {`
`122`	`123`	`return xerrors.Errorf("expand directory: %w", err)`