feat: cli configs should not be space sensitive (#1668)

Emyrk · kylecarbs · commit 405ec7d8567b · 2022-06-10T17:02:28.000Z
diff --git a/cli/root.go b/cli/root.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"net/url"
 	"os"
+	"strings"
 	"time"
 
 	"github.com/kirsle/configdir"
@@ -115,7 +116,7 @@ func createClient(cmd *cobra.Command) (*codersdk.Client, error) {
 			return nil, err
 		}
 	}
-	serverURL, err := url.Parse(rawURL)
+	serverURL, err := url.Parse(strings.TrimSpace(rawURL))
 	if err != nil {
 		return nil, err
 	}
@@ -127,7 +128,7 @@ func createClient(cmd *cobra.Command) (*codersdk.Client, error) {
 		}
 	}
 	client := codersdk.New(serverURL)
-	client.SessionToken = token
+	client.SessionToken = strings.TrimSpace(token)
 	return client, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import (`
`4`	`4`	`"fmt"`
`5`	`5`	`"net/url"`
`6`	`6`	`"os"`
	`7`	`+ "strings"`
`7`	`8`	`"time"`
`8`	`9`
`9`	`10`	`"github.com/kirsle/configdir"`
`@@ -115,7 +116,7 @@ func createClient(cmd cobra.Command) (codersdk.Client, error) {`
`115`	`116`	`return nil, err`
`116`	`117`	`}`
`117`	`118`	`}`
`118`		`- serverURL, err := url.Parse(rawURL)`
	`119`	`+ serverURL, err := url.Parse(strings.TrimSpace(rawURL))`
`119`	`120`	`if err != nil {`
`120`	`121`	`return nil, err`
`121`	`122`	`}`
`@@ -127,7 +128,7 @@ func createClient(cmd cobra.Command) (codersdk.Client, error) {`
`127`	`128`	`}`
`128`	`129`	`}`
`129`	`130`	`client := codersdk.New(serverURL)`
`130`		`- client.SessionToken = token`
	`131`	`+ client.SessionToken = strings.TrimSpace(token)`
`131`	`132`	`return client, nil`
`132`	`133`	`}`
`133`	`134`