rm temp file on failure

johnstcn · johnstcn · commit 4158ed7177a5 · 2024-03-01T14:51:48.000Z
diff --git a/cli/support.go b/cli/support.go
@@ -86,6 +86,7 @@ func (r *RootCmd) support() *clibase.Cmd {
 			}
 
 			if err := writeBundle(bun, zwr); err != nil {
+				_ = os.Remove(outputPath) // best effort
 				return xerrors.Errorf("write support bundle to %s: %w", outputPath, err)
 			}
 			return nil

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ func (r RootCmd) support() clibase.Cmd {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`if err := writeBundle(bun, zwr); err != nil {`
	`89`	`+ _ = os.Remove(outputPath) // best effort`
`89`	`90`	`return xerrors.Errorf("write support bundle to %s: %w", outputPath, err)`
`90`	`91`	`}`
`91`	`92`	`return nil`