RecordingAuthorizer: AllAsserted: provide more information on missed calls

johnstcn · johnstcn · commit 4357a3cb6ff5 · 2023-02-02T15:12:57.000Z
diff --git a/coderd/coderdtest/authorize.go b/coderd/coderdtest/authorize.go
@@ -573,15 +573,15 @@ func (*RecordingAuthorizer) Pair(action rbac.Action, object rbac.Objecter) Actio
 func (r *RecordingAuthorizer) AllAsserted() error {
 	r.RLock()
 	defer r.RUnlock()
-	missed := 0
+	missed := []authCall{}
 	for _, c := range r.Called {
 		if !c.asserted {
-			missed++
+			missed = append(missed, c)
 		}
 	}
 
-	if missed > 0 {
-		return xerrors.Errorf("missed %d calls", missed)
+	if len(missed) > 0 {
+		return xerrors.Errorf("missed calls: %+v", missed)
 	}
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -573,15 +573,15 @@ func (*RecordingAuthorizer) Pair(action rbac.Action, object rbac.Objecter) Actio`
`573`	`573`	`func (r *RecordingAuthorizer) AllAsserted() error {`
`574`	`574`	`r.RLock()`
`575`	`575`	`defer r.RUnlock()`
`576`		`- missed := 0`
	`576`	`+ missed := []authCall{}`
`577`	`577`	`for _, c := range r.Called {`
`578`	`578`	`if !c.asserted {`
`579`		`- missed++`
	`579`	`+ missed = append(missed, c)`
`580`	`580`	`}`
`581`	`581`	`}`
`582`	`582`
`583`		`- if missed > 0 {`
`584`		`- return xerrors.Errorf("missed %d calls", missed)`
	`583`	`+ if len(missed) > 0 {`
	`584`	`+ return xerrors.Errorf("missed calls: %+v", missed)`
`585`	`585`	`}`
`586`	`586`	`return nil`
`587`	`587`	`}`