chore: better scroll behavior on history overflow

brettkolodny · brettkolodny · commit 4496305d1f3a · 2025-08-13T18:51:24.000Z
diff --git a/site/src/modules/dashboard/DashboardLayout.tsx b/site/src/modules/dashboard/DashboardLayout.tsx
@@ -23,10 +23,10 @@ export const DashboardLayout: FC = () => {
 			{canViewDeployment && <LicenseBanner />}
 			<AnnouncementBanners />
 
-			<div className="flex flex-col min-h-full">
+			<div className="flex flex-col h-screen">
 				<Navbar />
 
-				<div className="flex flex-col flex-1">
+				<div className="flex flex-col flex-1 min-h-0">
 					<Suspense fallback={<Loader />}>
 						<Outlet />
 					</Suspense>
diff --git a/site/src/modules/dashboard/Navbar/NavbarView.tsx b/site/src/modules/dashboard/Navbar/NavbarView.tsx
@@ -51,7 +51,7 @@ export const NavbarView: FC<NavbarViewProps> = ({
 	const webPush = useWebpushNotifications();
 
 	return (
-		<div className="border-0 border-b border-solid h-[72px] flex items-center leading-none px-6">
+		<div className="border-0 border-b border-solid h-[72px] min-h-[72px] flex items-center leading-none px-6">
 			<NavLink to="/workspaces">
 				{logo_url ? (
 					<ExternalImage className="h-7" src={logo_url} alt="Custom Logo" />
diff --git a/site/src/pages/WorkspacePage/Workspace.tsx b/site/src/pages/WorkspacePage/Workspace.tsx
@@ -23,6 +23,7 @@ import {
 } from "./WorkspaceBuildProgress";
 import { WorkspaceDeletedBanner } from "./WorkspaceDeletedBanner";
 import { WorkspaceTopbar } from "./WorkspaceTopbar";
+import { height } from "@mui/system";
 
 interface WorkspaceProps {
 	workspace: TypesGen.Workspace;
@@ -99,7 +100,7 @@ export const Workspace: FC<WorkspaceProps> = ({
 		workspacePending && !haveBuildLogs && !provisionersHealthy && !isRestarting;
 
 	return (
-		<div className="flex flex-col overflow-hidden flex-1">
+		<div className="flex flex-col flex-1 min-h-0">
 			<WorkspaceTopbar
 				workspace={workspace}
 				template={template}
@@ -118,7 +119,7 @@ export const Workspace: FC<WorkspaceProps> = ({
 				handleToggleFavorite={handleToggleFavorite}
 			/>
 
-			<div className="flex flex-1">
+			<div className="flex flex-1 min-h-0">
 				<div className="flex">
 					<div className="flex flex-col h-full overflow-y-auto border-solid border-0 border-r border-r-border">
 						<SidebarIconButton
