Skip to content

Commit 44a59c8

Browse files
BrunoQuaresmaBrunoQuaresma
committed
Fix e2e tests
1 parent 86b52ee commit 44a59c8

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

‎site/e2e/helpers.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ export const createTemplate = async (
276276

277277
const name = randomName();
278278
await page.getByLabel("Name *").fill(name);
279-
await page.getByRole("button", { name: /create template/i }).click();
279+
await page.getByRole("button", { name: /save/i }).click();
280280
await expectUrl(page).toHavePathName(
281281
organizationsEnabled
282282
? `/templates/${orgName}/${name}/files`
@@ -298,7 +298,7 @@ export const createGroup = async (page: Page): Promise<string> => {
298298

299299
const name = randomName();
300300
await page.getByLabel("Name", { exact: true }).fill(name);
301-
await page.getByRole("button", { name: /create group/i }).click();
301+
await page.getByRole("button", { name: /save/i }).click();
302302
await expectUrl(page).toHavePathName(`/groups/${name}`);
303303
return name;
304304
};
@@ -1091,7 +1091,7 @@ export async function createUser(
10911091
// as the label for the currently active option.
10921092
const passwordField = page.locator("input[name=password]");
10931093
await passwordField.fill(password);
1094-
await page.getByRole("button", { name: "Save" }).click();
1094+
await page.getByRole("button", { name: /save/i }).click();
10951095
await expect(page.getByText("Successfully created user.")).toBeVisible();
10961096

10971097
await expect(page).toHaveTitle("Users - Coder");

‎site/e2e/tests/deployment/appearance.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ test("set application name", async ({ page }) => {
2020
await form
2121
.getByLabel("Application name", { exact: true })
2222
.fill(applicationName);
23-
await form.getByRole("button", { name: /save/i }).click();
23+
await form.getByRole("button", { name: "Submit" }).click();
2424

2525
// Open a new session without cookies to see the login page
2626
const browser = await chromium.launch();

‎site/e2e/tests/deployment/idpOrgSync.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,14 @@ test.describe("IdpOrgSyncPage", () => {
6767
const syncField = page.getByRole("textbox", {
6868
name: "Organization sync field",
6969
});
70-
const saveButton = page.getByRole("button", { name: "Save" }).first();
70+
const saveButton = page.getByRole("button", { name: /save/i }).first();
7171

7272
await expect(saveButton).toBeDisabled();
7373

7474
await syncField.fill("test-field");
7575
await expect(saveButton).toBeEnabled();
7676

77-
await page.getByRole("button", { name: "Save" }).click();
77+
await page.getByRole("button", { name: /save/i }).click();
7878

7979
await expect(
8080
page.getByText("Organization sync settings updated."),

‎site/e2e/tests/organizationGroups.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test("create group", async ({ page }) => {
3434
const displayName = `Group ${name}`;
3535
await page.getByLabel("Display Name").fill(displayName);
3636
await page.getByLabel("Avatar URL").fill("/emojis/1f60d.png");
37-
await page.getByRole("button", { name: "Save" }).click();
37+
await page.getByRole("button", { name: /save/i }).click();
3838

3939
await expectUrl(page).toHavePathName(
4040
`/organizations/${org.name}/groups/${name}`,
@@ -91,7 +91,7 @@ test("change quota settings", async ({ page }) => {
9191

9292
// Update Quota
9393
await page.getByLabel("Quota Allowance").fill("100");
94-
await page.getByRole("button", { name: "Create group" }).click();
94+
await page.getByRole("button", { name: /save/i }).click();
9595

9696
// We should get sent back to the group page afterwards
9797
expectUrl(page).toHavePathName(

‎site/e2e/tests/organizations.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ test("create and delete organization", async ({ page }) => {
2323
await page.getByLabel("Display name").fill(`Org ${name}`);
2424
await page.getByLabel("Description").fill(`Org description ${name}`);
2525
await page.getByLabel("Icon", { exact: true }).fill("/emojis/1f957.png");
26-
await page.getByRole("button", { name: "Create organization" }).click();
26+
await page.getByRole("button", { name: /save/i }).click();
2727

2828
// Expect to be redirected to the new organization
2929
await expectUrl(page).toHavePathName(`/organizations/${name}`);
@@ -32,7 +32,7 @@ test("create and delete organization", async ({ page }) => {
3232
const newName = randomName();
3333
await page.getByLabel("Slug").fill(newName);
3434
await page.getByLabel("Description").fill(`Org description ${newName}`);
35-
await page.getByRole("button", { name: "Create organization" }).click();
35+
await page.getByRole("button", { name: /save/i }).click();
3636

3737
// Expect to be redirected when renaming the organization
3838
await expectUrl(page).toHavePathName(`/organizations/${newName}`);

‎site/e2e/tests/organizations/customRoles/customRoles.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ test.describe("CustomRolesPage", () => {
8787
await expect(organizationMemberCheckbox).toBeVisible();
8888
await organizationMemberCheckbox.click();
8989

90-
const saveButton = page.getByRole("button", { name: "Save" }).first();
90+
const saveButton = page.getByRole("button", { name: /save/i }).first();
9191
await expect(saveButton).toBeVisible();
9292
await saveButton.click();
9393

‎site/src/pages/CreateUserPage/CreateUserPage.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const fillForm = async ({
3535
await userEvent.type(loginTypeField, "password");
3636
await userEvent.type(passwordField as HTMLElement, password);
3737
const submitButton = screen.getByRole("button", {
38-
name: "Save",
38+
name: /save/i,
3939
});
4040
fireEvent.click(submitButton);
4141
};

0 commit comments

Comments
 (0)