feat(site): show entity name in DeleteDialog (#9347)

ammario · web-flow · commit 451ca042ceb7 · 2023-08-25T22:16:30.000Z
diff --git a/site/src/components/Dialogs/DeleteDialog/DeleteDialog.tsx b/site/src/components/Dialogs/DeleteDialog/DeleteDialog.tsx
@@ -39,7 +39,7 @@ export const DeleteDialog: FC<PropsWithChildren<DeleteDialogProps>> = ({
       <Maybe condition={info !== undefined}>
         <p className={styles.warning}>{info}</p>
       </Maybe>
-      <p>{t("deleteDialog.confirm", { entity })}</p>
+      <p>{t("deleteDialog.confirm", { entity, name })}</p>
 
       <form
         onSubmit={(e) => {
diff --git a/site/src/i18n/en/common.json b/site/src/i18n/en/common.json
@@ -16,7 +16,7 @@
   "deleteDialog": {
     "title": "Delete {{entity}}",
     "intro": "Deleting this {{entity}} is irreversible!",
-    "confirm": "Are you sure you want to proceed? Type the name of this {{entity}} below to confirm.",
+    "confirm": "Are you sure you want to proceed? Type {{name}} below to confirm.",
     "confirmLabel": "Name of {{entity}} to delete",
     "incorrectName": "Incorrect {{entity}} name."
   },
diff --git a/site/src/pages/UsersPage/UsersPage.test.tsx b/site/src/pages/UsersPage/UsersPage.test.tsx
@@ -72,7 +72,11 @@ const deleteUser = async (setupActionSpies: () => void) => {
   // Check if the confirm message is displayed
   const confirmDialog = await screen.findByRole("dialog")
   expect(confirmDialog).toHaveTextContent(
-    t("deleteDialog.confirm", { ns: "common", entity: "user" }).toString(),
+    t("deleteDialog.confirm", {
+      ns: "common",
+      entity: "user",
+      name: MockUser2.username,
+    }).toString(),
   )
 
   // Confirm with text input
