address PR comments and add test for OIDC defaults

johnstcn · johnstcn · commit 458a742066b4 · 2022-11-24T09:40:30.000Z
diff --git a/cli/deployment/config_test.go b/cli/deployment/config_test.go
@@ -122,6 +122,18 @@ func TestConfig(t *testing.T) {
 			require.Equal(t, config.Trace.Enable.Value, true)
 			require.Equal(t, config.Trace.HoneycombAPIKey.Value, "my-honeycomb-key")
 		},
+	}, {
+		Name: "OIDC_Defaults",
+		Env:  map[string]string{},
+		Valid: func(config *codersdk.DeploymentConfig) {
+			require.Empty(t, config.OIDC.IssuerURL.Value)
+			require.Empty(t, config.OIDC.EmailDomain.Value)
+			require.Empty(t, config.OIDC.ClientID.Value)
+			require.Empty(t, config.OIDC.ClientSecret.Value)
+			require.True(t, config.OIDC.AllowSignups.Value)
+			require.ElementsMatch(t, config.OIDC.Scopes.Value, []string{"openid", "email", "profile"})
+			require.False(t, config.OIDC.IgnoreEmailVerified.Value)
+		},
 	}, {
 		Name: "OIDC",
 		Env: map[string]string{
@@ -138,9 +150,9 @@ func TestConfig(t *testing.T) {
 			require.Equal(t, config.OIDC.EmailDomain.Value, "coder.com")
 			require.Equal(t, config.OIDC.ClientID.Value, "client")
 			require.Equal(t, config.OIDC.ClientSecret.Value, "secret")
-			require.False(t, config.OIDC.AllowSignups.Value, false)
+			require.False(t, config.OIDC.AllowSignups.Value)
 			require.Equal(t, config.OIDC.Scopes.Value, []string{"something", "here"})
-			require.Equal(t, config.OIDC.IgnoreEmailVerified.Value, true)
+			require.True(t, config.OIDC.IgnoreEmailVerified.Value)
 		},
 	}, {
 		Name: "GitHub",
