Skip to content

Commit 4608462

Browse files
committed
Fix comment about system functions
1 parent 4daa878 commit 4608462

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

coderd/authzquery/system.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ import (
99
"github.com/coder/coder/coderd/database"
1010
)
1111

12-
// TODO: @emyrk should we name system functions differently to indicate a user
13-
// cannot call them? Maybe we should have a separate interface for system functions?
14-
// So you'd do `authzQ.System().GetDERPMeshKey(ctx)` or something like that?
15-
// Cian: yes. Let's do it.
12+
// TODO: All these system functions should have rbac objects created to allow
13+
// only system roles to call them. No user roles should ever have the permission
14+
// to these objects. Might need a negative permission on the `Owner` role to
15+
// prevent owners.
1616

1717
func (q *AuthzQuerier) UpdateUserLinkedID(ctx context.Context, arg database.UpdateUserLinkedIDParams) (database.UserLink, error) {
1818
return q.db.UpdateUserLinkedID(ctx, arg)

0 commit comments

Comments
 (0)