Handle unknown types better

Emyrk · Emyrk · commit 462ebeb3c9bb · 2022-04-28T09:25:09.000-05:00
diff --git a/codersdk/client.go b/codersdk/client.go
@@ -114,6 +114,7 @@ func readBodyAsError(res *http.Response) error {
 }
 
 // Error represents an unaccepted or invalid request to the API.
+// @typescript-ignore Error
 type Error struct {
 	httpapi.Response
 
diff --git a/scripts/apitypings/main.go b/scripts/apitypings/main.go
@@ -367,11 +367,15 @@ func (g *Generator) typescriptType(ty types.Type) (TypescriptType, error) {
 		case "time.Time":
 			// We really should come up with a standard for time.
 			return TypescriptType{ValueType: "string"}, nil
+		case "database/sql.NullTime":
+			return TypescriptType{ValueType: "string", Optional: true}, nil
+		case "github.com/google/uuid.NullUUID":
+			return TypescriptType{ValueType: "string", Optional: true}, nil
 		}
 
 		// If it's a struct, just use the name of the struct type
 		if _, ok := n.Underlying().(*types.Struct); ok {
-			return TypescriptType{ValueType: name, Comment: "Unknown named type, this might not work"}, nil
+			return TypescriptType{ValueType: "any", Comment: fmt.Sprintf("Named type %q unknown, using \"any\"", n.String())}, nil
 		}
 
 		// Defer to the underlying type.
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ func readBodyAsError(res *http.Response) error {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`// Error represents an unaccepted or invalid request to the API.`
	`117`	`+// @typescript-ignore Error`
`117`	`118`	`type Error struct {`
`118`	`119`	`httpapi.Response`
`119`	`120`