test: add is-within-range test

evgeniy-scherbina · evgeniy-scherbina · commit 4687f2abaf90 · 2025-06-04T16:02:34.000Z
diff --git a/coderd/prebuilds/global_snapshot.go b/coderd/prebuilds/global_snapshot.go
@@ -50,7 +50,7 @@ func (s GlobalSnapshot) FilterByPreset(presetID uuid.UUID) (*PresetSnapshot, err
 	if !found {
 		return nil, xerrors.Errorf("no preset found with ID %q", presetID)
 	}
-	
+
 	prebuildSchedules := slice.Filter(s.PrebuildSchedules, func(schedule database.TemplateVersionPresetPrebuildSchedule) bool {
 		return schedule.PresetID == presetID
 	})
diff --git a/coderd/schedule/cron/cron_test.go b/coderd/schedule/cron/cron_test.go
@@ -163,6 +163,89 @@ func Test_Weekly(t *testing.T) {
 	}
 }
 
+func TestIsWithinRange(t *testing.T) {
+	t.Parallel()
+	testCases := []struct {
+		name                string
+		spec                string
+		at                  time.Time
+		expectedWithinRange bool
+	}{
+		{
+			name:                "Right before the start of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 8:58:59 UTC"),
+			expectedWithinRange: false,
+		},
+		{
+			name:                "Start of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 8:59:00 UTC"),
+			expectedWithinRange: true,
+		},
+		{
+			name:                "9AM - One minute after the start of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 9:00:00 UTC"),
+			expectedWithinRange: true,
+		},
+		{
+			name:                "2PM - The middle of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 14:00:00 UTC"),
+			expectedWithinRange: true,
+		},
+		{
+			name:                "6PM - Around one hour before the end of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 18:00:00 UTC"),
+			expectedWithinRange: true,
+		},
+		{
+			name:                "End of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 18:58:59 UTC"),
+			expectedWithinRange: true,
+		},
+		{
+			name:                "Right after the end of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 18:59:00 UTC"),
+			expectedWithinRange: false,
+		},
+		{
+			name:                "7PM - Around one minute after the end of the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 19:00:00 UTC"),
+			expectedWithinRange: false,
+		},
+		{
+			name:                "2AM - Significantly outside the time range",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 02:00:00 UTC"),
+			expectedWithinRange: false,
+		},
+	}
+
+	for _, testCase := range testCases {
+		testCase := testCase
+		t.Run(testCase.name, func(t *testing.T) {
+			t.Parallel()
+			sched, err := cron.Weekly(testCase.spec)
+			require.NoError(t, err)
+			withinRange := sched.IsWithinRange(testCase.at)
+			require.Equal(t, testCase.expectedWithinRange, withinRange)
+		})
+	}
+}
+
+func mustParseTime(t *testing.T, layout, value string) time.Time {
+	t.Helper()
+	parsedTime, err := time.Parse(layout, value)
+	require.NoError(t, err)
+	return parsedTime
+}
+
 func mustLocation(t *testing.T, s string) *time.Location {
 	t.Helper()
 	loc, err := time.LoadLocation(s)

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func (s GlobalSnapshot) FilterByPreset(presetID uuid.UUID) (*PresetSnapshot, err`
`50`	`50`	`if !found {`
`51`	`51`	`return nil, xerrors.Errorf("no preset found with ID %q", presetID)`
`52`	`52`	`}`
`53`		`-`
	`53`	`+`
`54`	`54`	`prebuildSchedules := slice.Filter(s.PrebuildSchedules, func(schedule database.TemplateVersionPresetPrebuildSchedule) bool {`
`55`	`55`	`return schedule.PresetID == presetID`
`56`	`56`	`})`