WIP

ibetitsmike · ibetitsmike · commit 4698231b08f1 · 2025-04-15T11:42:00.000Z
diff --git a/coderd/httpmw/prometheus.go b/coderd/httpmw/prometheus.go
@@ -102,6 +102,10 @@ func Prometheus(register prometheus.Registerer) func(http.Handler) http.Handler
 
 func getRoutePattern(r *http.Request) string {
 	rctx := chi.RouteContext(r.Context())
+	if rctx == nil {
+		return ""
+	}
+
 	if pattern := rctx.RoutePattern(); pattern != "" {
 		// Pattern is already available
 		return pattern
diff --git a/coderd/httpmw/prometheus_internal_test.go b/coderd/httpmw/prometheus_internal_test.go
@@ -0,0 +1,100 @@
+package httpmw
+
+import (
+	"context"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/go-chi/chi/v5"
+	"github.com/prometheus/client_golang/prometheus"
+	"github.com/stretchr/testify/require"
+
+	"github.com/coder/coder/v2/coderd/tracing"
+)
+
+func TestPrometheus(t *testing.T) {
+	t.Parallel()
+	t.Run("All", func(t *testing.T) {
+		t.Parallel()
+		req := httptest.NewRequest("GET", "/", nil)
+		req = req.WithContext(context.WithValue(req.Context(), chi.RouteCtxKey, chi.NewRouteContext()))
+		res := &tracing.StatusWriter{ResponseWriter: httptest.NewRecorder()}
+		reg := prometheus.NewRegistry()
+		Prometheus(reg)(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			w.WriteHeader(http.StatusOK)
+		})).ServeHTTP(res, req)
+		metrics, err := reg.Gather()
+		require.NoError(t, err)
+		require.Greater(t, len(metrics), 0)
+	})
+}
+
+func TestGetRoutePattern(t *testing.T) {
+	t.Parallel()
+	reg := prometheus.NewRegistry()
+	promMW := Prometheus(reg)
+	// Create a test router with some routes
+	r := chi.NewRouter()
+	r.With(promMW).Get("/api/v2/workspaces/{workspace}", func(w http.ResponseWriter, r *http.Request) {})
+	r.With(promMW).Get("/api/v2/users/{user}", func(w http.ResponseWriter, r *http.Request) {})
+	r.With(promMW).Get("/static/*", func(w http.ResponseWriter, r *http.Request) {})
+
+	tests := []struct {
+		name     string
+		method   string
+		path     string
+		expected string
+	}{
+		{
+			name:     "PatternAlreadyAvailable",
+			method:   "GET",
+			path:     "/api/v2/workspaces/test",
+			expected: "/api/v2/workspaces/{workspace}",
+		},
+		{
+			name:     "UserRoute",
+			method:   "GET",
+			path:     "/api/v2/users/john",
+			expected: "/api/v2/users/{user}",
+		},
+		{
+			name:     "StaticRoute",
+			method:   "GET",
+			path:     "/static/css/style.css",
+			expected: "/static/*",
+		},
+		{
+			name:     "NoMatchingRoute",
+			method:   "GET",
+			path:     "/nonexistent",
+			expected: "",
+		},
+		{
+			name:     "FrontendRoute",
+			method:   "GET",
+			path:     "/",
+			expected: "",
+		},
+	}
+
+	for _, tt := range tests {
+		tt := tt
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
+			req := httptest.NewRequest(tt.method, tt.path, nil)
+
+			sw := &tracing.StatusWriter{ResponseWriter: httptest.NewRecorder()}
+
+			r.ServeHTTP(sw, req)
+
+			metrics, err := reg.Gather()
+			require.NoError(t, err)
+			require.Greater(t, len(metrics), 0)
+
+			// Verify the result
+			// require.Equal(t, tt.expected, pattern, "unexpected route pattern")
+		})
+	}
+}
diff --git a/coderd/httpmw/prometheus_test.go b/coderd/httpmw/prometheus_test.go
