fix: use new context after t.Parallel in TestOAuthAppSecrets

spikecurtis · web-flow · commit 4825b7ccd290 · 2024-01-27T08:45:43.000+04:00
c.f. https://coder.com/blog/go-testing-contexts-and-t-parallel fixes flakes like https://github.com/coder/coder/runs/20856469613
diff --git a/enterprise/coderd/oauth2_test.go b/enterprise/coderd/oauth2_test.go
@@ -271,25 +271,26 @@ func TestOAuthAppSecrets(t *testing.T) {
 		},
 	}})
 
-	ctx := testutil.Context(t, testutil.WaitLong)
+	topCtx := testutil.Context(t, testutil.WaitLong)
 
 	// Make some apps.
 	//nolint:gocritic // OAauth2 app management requires owner permission.
-	app1, err := client.PostOAuth2ProviderApp(ctx, codersdk.PostOAuth2ProviderAppRequest{
+	app1, err := client.PostOAuth2ProviderApp(topCtx, codersdk.PostOAuth2ProviderAppRequest{
 		Name:        "razzle-dazzle",
 		CallbackURL: "http://localhost",
 	})
 	require.NoError(t, err)
 
 	//nolint:gocritic // OAauth2 app management requires owner permission.
-	app2, err := client.PostOAuth2ProviderApp(ctx, codersdk.PostOAuth2ProviderAppRequest{
+	app2, err := client.PostOAuth2ProviderApp(topCtx, codersdk.PostOAuth2ProviderAppRequest{
 		Name:        "razzle-dazzle-the-sequel",
 		CallbackURL: "http://localhost",
 	})
 	require.NoError(t, err)
 
 	t.Run("DeleteNonExisting", func(t *testing.T) {
 		t.Parallel()
+		ctx := testutil.Context(t, testutil.WaitLong)
 
 		// Should not be able to create secrets for a non-existent app.
 		//nolint:gocritic // OAauth2 app management requires owner permission.
@@ -318,6 +319,7 @@ func TestOAuthAppSecrets(t *testing.T) {
 
 	t.Run("OK", func(t *testing.T) {
 		t.Parallel()
+		ctx := testutil.Context(t, testutil.WaitLong)
 
 		// No secrets yet.
 		//nolint:gocritic // OAauth2 app management requires owner permission.
