fix: Leaking yamux session after HTTP handler is closed

kylecarbs · kylecarbs · commit 4932ba78ff15 · 2022-02-18T16:45:55.000Z
Closes #317. We depended on the context canceling the yamux connection, but this isn't a sync operation. Explicitly calling close ensures the handler waits for yamux to complete before exit.
diff --git a/coderd/provisionerdaemons.go b/coderd/provisionerdaemons.go
@@ -84,6 +84,9 @@ func (api *api) provisionerDaemonsServe(rw http.ResponseWriter, r *http.Request)
 		_ = conn.Close(websocket.StatusInternalError, fmt.Sprintf("multiplex server: %s", err))
 		return
 	}
+	defer func() {
+		_ = session.Close()
+	}()
 	mux := drpcmux.New()
 	err = proto.DRPCRegisterProvisionerDaemon(mux, &provisionerdServer{
 		ID:           daemon.ID,
