processedUsers

mtojek · mtojek · commit 498b89b57c24 · 2024-09-17T09:46:36.000+02:00
diff --git a/coderd/notifications/reports/generator.go b/coderd/notifications/reports/generator.go
@@ -111,7 +111,7 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat
 		return xerrors.Errorf("unable to fetch failed workspace builds: %w", err)
 	}
 
-	reportGeneratedNow := map[uuid.UUID]bool{}
+	processedUsers := map[uuid.UUID]bool{}
 	for _, stats := range statsRows {
 		var failedBuilds []database.GetFailedWorkspaceBuildsByTemplateIDRow
 		reportData := map[string]any{}
@@ -150,7 +150,7 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat
 				continue
 			}
 
-			reportGeneratedNow[templateAdmin.ID] = true
+			processedUsers[templateAdmin.ID] = true
 
 			if len(failedBuilds) == 0 {
 				// no failed workspace builds, no need to send the report
@@ -176,14 +176,14 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat
 		}
 	}
 
-	for recipient := range reportGeneratedNow {
+	for u := range processedUsers {
 		err = db.UpsertReportGeneratorLog(ctx, database.UpsertReportGeneratorLogParams{
-			UserID:                 recipient,
+			UserID:                 u,
 			NotificationTemplateID: notifications.TemplateWorkspaceBuildsFailedReport,
 			LastGeneratedAt:        dbtime.Time(now).UTC(),
 		})
 		if err != nil {
-			logger.Error(ctx, "unable to update report generator logs", slog.F("user_id", recipient), slog.Error(err))
+			logger.Error(ctx, "unable to update report generator logs", slog.F("user_id", u), slog.Error(err))
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat`
`111`	`111`	`return xerrors.Errorf("unable to fetch failed workspace builds: %w", err)`
`112`	`112`	`}`
`113`	`113`
`114`		`- reportGeneratedNow := map[uuid.UUID]bool{}`
	`114`	`+ processedUsers := map[uuid.UUID]bool{}`
`115`	`115`	`for _, stats := range statsRows {`
`116`	`116`	`var failedBuilds []database.GetFailedWorkspaceBuildsByTemplateIDRow`
`117`	`117`	`reportData := map[string]any{}`
`@@ -150,7 +150,7 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat`
`150`	`150`	`continue`
`151`	`151`	`}`
`152`	`152`
`153`		`- reportGeneratedNow[templateAdmin.ID] = true`
	`153`	`+ processedUsers[templateAdmin.ID] = true`
`154`	`154`
`155`	`155`	`if len(failedBuilds) == 0 {`
`156`	`156`	`// no failed workspace builds, no need to send the report`
`@@ -176,14 +176,14 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat`
`176`	`176`	`}`
`177`	`177`	`}`
`178`	`178`
`179`		`- for recipient := range reportGeneratedNow {`
	`179`	`+ for u := range processedUsers {`
`180`	`180`	`err = db.UpsertReportGeneratorLog(ctx, database.UpsertReportGeneratorLogParams{`
`181`		`- UserID: recipient,`
	`181`	`+ UserID: u,`
`182`	`182`	`NotificationTemplateID: notifications.TemplateWorkspaceBuildsFailedReport,`
`183`	`183`	`LastGeneratedAt: dbtime.Time(now).UTC(),`
`184`	`184`	`})`
`185`	`185`	`if err != nil {`
`186`		`- logger.Error(ctx, "unable to update report generator logs", slog.F("user_id", recipient), slog.Error(err))`
	`186`	`+ logger.Error(ctx, "unable to update report generator logs", slog.F("user_id", u), slog.Error(err))`
`187`	`187`	`}`
`188`	`188`	`}`
`189`	`189`