rename classic_parameter_flow -> use_classic_parameter_flow

Emyrk · Emyrk · commit 4ada1645a6c2 · 2025-05-14T17:15:00.000-05:00
diff --git a/coderd/database/migrations/000326_version_dynamic_parameter_flow.down.sql b/coderd/database/migrations/000326_version_dynamic_parameter_flow.down.sql
@@ -1,7 +1,7 @@
 DROP VIEW template_with_names;
 
 -- Drop the column
-ALTER TABLE templates DROP COLUMN classic_parameter_flow;
+ALTER TABLE templates DROP COLUMN use_classic_parameter_flow;
 
 
 CREATE VIEW
diff --git a/coderd/database/migrations/000326_version_dynamic_parameter_flow.up.sql b/coderd/database/migrations/000326_version_dynamic_parameter_flow.up.sql
@@ -1,8 +1,8 @@
 -- Default to `false`. Users will have to manually opt back into the classic parameter flow.
 -- We want the new experience to be tried first.
-ALTER TABLE templates ADD COLUMN classic_parameter_flow BOOL NOT NULL DEFAULT false;
+ALTER TABLE templates ADD COLUMN use_classic_parameter_flow BOOL NOT NULL DEFAULT false;
 
-COMMENT ON COLUMN templates.classic_parameter_flow IS
+COMMENT ON COLUMN templates.use_classic_parameter_flow IS
 	'Determines whether to default to the dynamic parameter creation flow for this template '
 	'or continue using the legacy classic parameter creation flow.'
 	'This is a template wide setting, the template admin can revert to the classic flow if there are any issues. '
diff --git a/coderd/database/queries/templates.sql b/coderd/database/queries/templates.sql
@@ -125,7 +125,7 @@ SET
 	allow_user_cancel_workspace_jobs = $7,
 	group_acl = $8,
 	max_port_sharing_level = $9,
-	classic_parameter_flow = $10
+	use_classic_parameter_flow = $10
 WHERE
 	id = $1
 ;
diff --git a/codersdk/templates.go b/codersdk/templates.go
@@ -62,7 +62,7 @@ type Template struct {
 	RequireActiveVersion bool                         `json:"require_active_version"`
 	MaxPortShareLevel    WorkspaceAgentPortShareLevel `json:"max_port_share_level"`
 
-	ClassicParameterFlow bool `json:"classic_parameter_flow"`
+	UseClassicParameterFlow bool `json:"use_classic_parameter_flow"`
 }
 
 // WeekdaysToBitmap converts a list of weekdays to a bitmap in accordance with
@@ -252,12 +252,12 @@ type UpdateTemplateMeta struct {
 	// of the template.
 	DisableEveryoneGroupAccess bool                          `json:"disable_everyone_group_access"`
 	MaxPortShareLevel          *WorkspaceAgentPortShareLevel `json:"max_port_share_level,omitempty"`
-	// ClassicParameterFlow is a flag that switches the default behavior to use the classic
+	// UseClassicParameterFlow is a flag that switches the default behavior to use the classic
 	// parameter flow when creating a workspace. This only affects deployments with the experiment
 	// "dynamic-parameters" enabled. This setting will live for a period after the experiment is
 	// made the default.
 	// An "opt-out" is present in case the new feature breaks some existing templates.
-	ClassicParameterFlow *bool `json:"classic_parameter_flow,omitempty"`
+	UseClassicParameterFlow *bool `json:"use_classic_parameter_flow,omitempty"`
 }
 
 type TemplateExample struct {
diff --git a/enterprise/audit/table.go b/enterprise/audit/table.go
@@ -115,7 +115,7 @@ var auditableResourcesTypes = map[any]map[string]Action{
 		"deprecated":                        ActionTrack,
 		"max_port_sharing_level":            ActionTrack,
 		"activity_bump":                     ActionTrack,
-		"classic_parameter_flow":            ActionTrack,
+		"use_classic_parameter_flow":        ActionTrack,
 	},
 	&database.TemplateVersion{}: {
 		"id":                      ActionTrack,
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
@@ -47,7 +47,7 @@ export const validationSchema = Yup.object({
 	allow_user_cancel_workspace_jobs: Yup.boolean(),
 	icon: iconValidator,
 	require_active_version: Yup.boolean(),
-	classic_parameter_flow: Yup.boolean(),
+	use_classic_parameter_flow: Yup.boolean(),
 	deprecation_message: Yup.string(),
 	max_port_sharing_level: Yup.string().oneOf(WorkspaceAppSharingLevels),
 });
@@ -90,7 +90,7 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
 			deprecation_message: template.deprecation_message,
 			disable_everyone_group_access: false,
 			max_port_share_level: template.max_port_share_level,
-			classic_parameter_flow: template.classic_parameter_flow,
+			use_classic_parameter_flow: template.use_classic_parameter_flow,
 		},
 		validationSchema,
 		onSubmit,
@@ -228,9 +228,9 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
 						control={
 							<Checkbox
 								size="small"
-								id="classic_parameter_flow"
-								name="classic_parameter_flow"
-								checked={form.values.classic_parameter_flow}
+								id="use_classic_parameter_flow"
+								name="use_classic_parameter_flow"
+								checked={form.values.use_classic_parameter_flow}
 								onChange={form.handleChange}
 								disabled={false}
 							/>
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.test.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.test.tsx
@@ -54,7 +54,7 @@ const validFormValues: FormValues = {
 	require_active_version: false,
 	disable_everyone_group_access: false,
 	max_port_share_level: "owner",
-	classic_parameter_flow: false,
+	use_classic_parameter_flow: false,
 };
 
 const renderTemplateSettingsPage = async () => {
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -824,7 +824,7 @@ export const MockTemplate: TypesGen.Template = {
 	deprecated: false,
 	deprecation_message: "",
 	max_port_share_level: "public",
-	classic_parameter_flow: false,
+	use_classic_parameter_flow: false,
 };
 
 const MockTemplateVersionFiles: TemplateVersionFiles = {

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ SET`
`125`	`125`	`allow_user_cancel_workspace_jobs = $7,`
`126`	`126`	`group_acl = $8,`
`127`	`127`	`max_port_sharing_level = $9,`
`128`		`- classic_parameter_flow = $10`
	`128`	`+ use_classic_parameter_flow = $10`
`129`	`129`	`WHERE`
`130`	`130`	`id = $1`
`131`	`131`	`;`