Review fixes

mtojek · mtojek · commit 4c2279826c01 · 2025-09-05T11:02:51.000+02:00
diff --git a/site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPage.test.tsx b/site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPage.test.tsx
@@ -33,7 +33,6 @@ test("Users can fill the parameters and copy the open in coder url", async () =>
 	const workspaceName = screen.getByRole("textbox", {
 		name: "Workspace name",
 	});
-	await user.clear(workspaceName);
 	await user.type(workspaceName, "my-first-workspace");
 	const firstParameterField = screen.getByLabelText(
 		parameter1.display_name ?? parameter1.name,
diff --git a/site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPage.tsx b/site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPage.tsx
@@ -60,7 +60,7 @@ function getClipboardCopyContent(
 	const createWorkspaceUrl = `${deploymentUrl}/templates/${organization}/${templateName}/workspace`;
 	const createWorkspaceParams = new URLSearchParams(buttonValues);
 	if (createWorkspaceParams.get("name") === "") {
-		createWorkspaceParams.delete("name"); // skip default workspace name if undefined
+		createWorkspaceParams.delete("name"); // no default workspace name if empty
 	}
 	const buttonUrl = `${createWorkspaceUrl}?${createWorkspaceParams.toString()}`;
 
@@ -157,12 +157,7 @@ export const TemplateEmbedPageView: FC<TemplateEmbedPageViewProps> = ({
 								<Label className="text-md" htmlFor={defaultWorkspaceNameID}>
 									Workspace name
 								</Label>
-								<div
-									className={"text-sm mb-3"}
-									css={(theme) => ({
-										color: theme.palette.text.secondary,
-									})}
-								>
+								<div className={"text-sm text-content-secondary mb-3"}>
 									Default name for the new workspace
 								</div>
 								<Input
@@ -176,14 +171,8 @@ export const TemplateEmbedPageView: FC<TemplateEmbedPageViewProps> = ({
 										}));
 									}}
 								/>
-								<div
-									className="text-sm mt-1"
-									role="alert"
-									css={(theme) => ({
-										color: theme.palette.error.main,
-									})}
-								>
-									{workspaceNameError || "\u00A0"}
+								<div className="text-sm text-highlight-red mt-1" role="alert">
+									{workspaceNameError}
 								</div>
 							</div>
 
diff --git a/site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPageView.stories.tsx b/site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPageView.stories.tsx
@@ -6,6 +6,7 @@ import {
 	MockTemplateVersionParameter4,
 } from "testHelpers/entities";
 import type { Meta, StoryObj } from "@storybook/react-vite";
+import { screen, userEvent } from "storybook/test";
 import { TemplateEmbedPageView } from "./TemplateEmbedPage";
 
 const meta: Meta<typeof TemplateEmbedPageView> = {
@@ -35,3 +36,15 @@ export const WithParameters: Story = {
 		],
 	},
 };
+
+export const WrongWorkspaceName: Story = {
+	args: {
+		templateParameters: [MockTemplateVersionParameter1],
+	},
+	play: async () => {
+		const workspaceName = screen.getByRole("textbox", {
+			name: "Workspace name",
+		});
+		await userEvent.type(workspaceName, "b@d");
+	},
+};
