fix: Increase ptytest buffer to resolve flake

kylecarbs · kylecarbs · commit 4c7ebd25a55c · 2022-04-25T14:42:52.000Z
From investigating the following run: https://github.com/coder/coder/runs/6156348454?check_suite_focus=true It's believed that the cause is data being discarded due to the buffer filling up. This _might_ fix it, but not entirely sure.
diff --git a/agent/agent_test.go b/agent/agent_test.go
@@ -76,6 +76,11 @@ func TestAgent(t *testing.T) {
 		session.Stdin = ptty.Input()
 		err = session.Start(command)
 		require.NoError(t, err)
+		caret := "$"
+		if runtime.GOOS == "windows" {
+			caret = ">"
+		}
+		ptty.ExpectMatch(caret)
 		ptty.WriteLine("echo test")
 		ptty.ExpectMatch("test")
 		ptty.WriteLine("exit")
diff --git a/pty/ptytest/ptytest.go b/pty/ptytest/ptytest.go
@@ -60,7 +60,7 @@ func create(t *testing.T, ptty pty.PTY) *PTY {
 		PTY: ptty,
 
 		outputWriter: writer,
-		runeReader:   bufio.NewReaderSize(ptty.Output(), utf8.UTFMax),
+		runeReader:   bufio.NewReaderSize(ptty.Output(), 4096),
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ func create(t testing.T, ptty pty.PTY) PTY {`
`60`	`60`	`PTY: ptty,`
`61`	`61`
`62`	`62`	`outputWriter: writer,`
`63`		`- runeReader: bufio.NewReaderSize(ptty.Output(), utf8.UTFMax),`
	`63`	`+ runeReader: bufio.NewReaderSize(ptty.Output(), 4096),`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`