WIP

mtojek · mtojek · commit 4cef22b39eb0 · 2024-07-08T11:54:26.000+02:00
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -814,14 +814,6 @@ func (q *querier) customRoleEscalationCheck(ctx context.Context, actor rbac.Subj
 	return nil
 }
 
-func (q *querier) GetNotificationSettings(ctx context.Context) (string, error) {
-	panic("not implemented")
-}
-
-func (q *querier) UpsertNotificationSettings(ctx context.Context, value string) error {
-	panic("not implemented")
-}
-
 func (q *querier) AcquireLock(ctx context.Context, id int64) error {
 	return q.db.AcquireLock(ctx, id)
 }
@@ -1488,7 +1480,8 @@ func (q *querier) GetNotificationMessagesByStatus(ctx context.Context, arg datab
 }
 
 func (q *querier) GetNotificationsSettings(ctx context.Context) (string, error) {
-	panic("not implemented")
+	// No authz checks
+	return q.db.GetNotificationsSettings(ctx)
 }
 
 func (q *querier) GetOAuth2ProviderAppByID(ctx context.Context, id uuid.UUID) (database.OAuth2ProviderApp, error) {
@@ -3700,7 +3693,10 @@ func (q *querier) UpsertLogoURL(ctx context.Context, value string) error {
 }
 
 func (q *querier) UpsertNotificationsSettings(ctx context.Context, value string) error {
-	panic("not implemented")
+	if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceDeploymentConfig); err != nil {
+		return err
+	}
+	return q.db.UpsertNotificationsSettings(ctx, value)
 }
 
 func (q *querier) UpsertOAuthSigningKey(ctx context.Context, value string) error {
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -199,6 +199,7 @@ type data struct {
 	lastUpdateCheck         []byte
 	announcementBanners     []byte
 	healthSettings          []byte
+	notificationsSettings   []byte
 	applicationName         string
 	logoURL                 string
 	appSecurityKey          string
@@ -917,14 +918,6 @@ func (q *FakeQuerier) getLatestWorkspaceAppByTemplateIDUserIDSlugNoLock(ctx cont
 	return database.WorkspaceApp{}, sql.ErrNoRows
 }
 
-func (q *FakeQuerier) GetNotificationSettings(ctx context.Context) (string, error) {
-	panic("not implemented")
-}
-
-func (q *FakeQuerier) UpsertNotificationSettings(ctx context.Context, value string) error {
-	panic("not implemented")
-}
-
 func (*FakeQuerier) AcquireLock(_ context.Context, _ int64) error {
 	return xerrors.New("AcquireLock must only be called within a transaction")
 }
@@ -2769,7 +2762,14 @@ func (q *FakeQuerier) GetNotificationMessagesByStatus(_ context.Context, arg dat
 }
 
 func (q *FakeQuerier) GetNotificationsSettings(ctx context.Context) (string, error) {
-	panic("not implemented")
+	q.mutex.RLock()
+	defer q.mutex.RUnlock()
+
+	if q.notificationsSettings == nil {
+		return "{}", nil
+	}
+
+	return string(q.notificationsSettings), nil
 }
 
 func (q *FakeQuerier) GetOAuth2ProviderAppByID(_ context.Context, id uuid.UUID) (database.OAuth2ProviderApp, error) {
@@ -8725,8 +8725,12 @@ func (q *FakeQuerier) UpsertLogoURL(_ context.Context, data string) error {
 	return nil
 }
 
-func (q *FakeQuerier) UpsertNotificationsSettings(ctx context.Context, value string) error {
-	panic("not implemented")
+func (q *FakeQuerier) UpsertNotificationsSettings(_ context.Context, data string) error {
+	q.mutex.RLock()
+	defer q.mutex.RUnlock()
+
+	q.notificationsSettings = []byte(data)
+	return nil
 }
 
 func (q *FakeQuerier) UpsertOAuthSigningKey(_ context.Context, value string) error {

Original file line number	Diff line number	Diff line change
`@@ -814,14 +814,6 @@ func (q *querier) customRoleEscalationCheck(ctx context.Context, actor rbac.Subj`
`814`	`814`	`return nil`
`815`	`815`	`}`
`816`	`816`
`817`		`-func (q *querier) GetNotificationSettings(ctx context.Context) (string, error) {`
`818`		`- panic("not implemented")`
`819`		`-}`
`820`		`-`
`821`		`-func (q *querier) UpsertNotificationSettings(ctx context.Context, value string) error {`
`822`		`- panic("not implemented")`
`823`		`-}`
`824`		`-`
`825`	`817`	`func (q *querier) AcquireLock(ctx context.Context, id int64) error {`
`826`	`818`	`return q.db.AcquireLock(ctx, id)`
`827`	`819`	`}`
`@@ -1488,7 +1480,8 @@ func (q *querier) GetNotificationMessagesByStatus(ctx context.Context, arg datab`
`1488`	`1480`	`}`
`1489`	`1481`
`1490`	`1482`	`func (q *querier) GetNotificationsSettings(ctx context.Context) (string, error) {`
`1491`		`- panic("not implemented")`
	`1483`	`+ // No authz checks`
	`1484`	`+ return q.db.GetNotificationsSettings(ctx)`
`1492`	`1485`	`}`
`1493`	`1486`
`1494`	`1487`	`func (q *querier) GetOAuth2ProviderAppByID(ctx context.Context, id uuid.UUID) (database.OAuth2ProviderApp, error) {`
`@@ -3700,7 +3693,10 @@ func (q *querier) UpsertLogoURL(ctx context.Context, value string) error {`
`3700`	`3693`	`}`
`3701`	`3694`
`3702`	`3695`	`func (q *querier) UpsertNotificationsSettings(ctx context.Context, value string) error {`
`3703`		`- panic("not implemented")`
	`3696`	`+ if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceDeploymentConfig); err != nil {`
	`3697`	`+ return err`
	`3698`	`+ }`
	`3699`	`+ return q.db.UpsertNotificationsSettings(ctx, value)`
`3704`	`3700`	`}`
`3705`	`3701`
`3706`	`3702`	`func (q *querier) UpsertOAuthSigningKey(ctx context.Context, value string) error {`