Update roles

Emyrk · Emyrk · commit 4d16bfca37f6 · 2024-05-14T18:01:23.000-05:00
diff --git a/coderd/rbac/object_gen.go b/coderd/rbac/object_gen.go
diff --git a/coderd/rbac/object_test.go b/coderd/rbac/object_test.go
@@ -184,14 +184,14 @@ func TestAllResources(t *testing.T) {
 	var typeNames []string
 	resources := rbac.AllResources()
 	for _, r := range resources {
-		if r.Type == "" {
-			t.Errorf("empty type name: %s", r.Type)
+		if r.RBACObject().Type == "" {
+			t.Errorf("empty type name: %s", r.RBACObject().Type)
 			continue
 		}
-		if slice.Contains(typeNames, r.Type) {
-			t.Errorf("duplicate type name: %s", r.Type)
+		if slice.Contains(typeNames, r.RBACObject().Type) {
+			t.Errorf("duplicate type name: %s", r.RBACObject().Type)
 			continue
 		}
-		typeNames = append(typeNames, r.Type)
+		typeNames = append(typeNames, r.RBACObject().Type)
 	}
 }
diff --git a/coderd/rbac/policy/policy.go b/coderd/rbac/policy/policy.go
@@ -244,6 +244,7 @@ var RBACPermissions = map[string]PermissionDefinition{
 	"assign_org_role": {
 		Actions: map[Action]ActionDefinition{
 			ActionAssign: actDef(0, "ability to assign org scoped roles"),
+			ActionRead:   actDef(0, "view what roles are assignable"),
 			ActionDelete: actDef(0, "ability to delete org scoped roles"),
 		},
 	},

Original file line number	Diff line number	Diff line change
`@@ -184,14 +184,14 @@ func TestAllResources(t *testing.T) {`
`184`	`184`	`var typeNames []string`
`185`	`185`	`resources := rbac.AllResources()`
`186`	`186`	`for _, r := range resources {`
`187`		`- if r.Type == "" {`
`188`		`- t.Errorf("empty type name: %s", r.Type)`
	`187`	`+ if r.RBACObject().Type == "" {`
	`188`	`+ t.Errorf("empty type name: %s", r.RBACObject().Type)`
`189`	`189`	`continue`
`190`	`190`	`}`
`191`		`- if slice.Contains(typeNames, r.Type) {`
`192`		`- t.Errorf("duplicate type name: %s", r.Type)`
	`191`	`+ if slice.Contains(typeNames, r.RBACObject().Type) {`
	`192`	`+ t.Errorf("duplicate type name: %s", r.RBACObject().Type)`
`193`	`193`	`continue`
`194`	`194`	`}`
`195`		`- typeNames = append(typeNames, r.Type)`
	`195`	`+ typeNames = append(typeNames, r.RBACObject().Type)`
`196`	`196`	`}`
`197`	`197`	`}`