fix: Parse CODER_GITAUTH_N_NO_REFRESH env var value instead of key (#7051)

kconley-sq · web-flow · commit 4dd5d794120c · 2023-04-11T09:18:17.000-05:00
diff --git a/cli/server.go b/cli/server.go
@@ -145,7 +145,7 @@ func ReadGitAuthProvidersFromEnv(environ []string) ([]codersdk.GitAuthConfig, er
 		case "REGEX":
 			provider.Regex = v.Value
 		case "NO_REFRESH":
-			b, err := strconv.ParseBool(key)
+			b, err := strconv.ParseBool(v.Value)
 			if err != nil {
 				return nil, xerrors.Errorf("parse bool: %s", v.Value)
 			}
diff --git a/cli/server_test.go b/cli/server_test.go
@@ -84,6 +84,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {
 			"CODER_GITAUTH_1_TOKEN_URL=google.com",
 			"CODER_GITAUTH_1_VALIDATE_URL=bing.com",
 			"CODER_GITAUTH_1_SCOPES=repo:read repo:write",
+			"CODER_GITAUTH_1_NO_REFRESH=true",
 		})
 		require.NoError(t, err)
 		require.Len(t, providers, 2)
@@ -99,6 +100,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {
 		assert.Equal(t, "google.com", providers[1].TokenURL)
 		assert.Equal(t, "bing.com", providers[1].ValidateURL)
 		assert.Equal(t, []string{"repo:read", "repo:write"}, providers[1].Scopes)
+		assert.Equal(t, true, providers[1].NoRefresh)
 	})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ func ReadGitAuthProvidersFromEnv(environ []string) ([]codersdk.GitAuthConfig, er`
`145`	`145`	`case "REGEX":`
`146`	`146`	`provider.Regex = v.Value`
`147`	`147`	`case "NO_REFRESH":`
`148`		`- b, err := strconv.ParseBool(key)`
	`148`	`+ b, err := strconv.ParseBool(v.Value)`
`149`	`149`	`if err != nil {`
`150`	`150`	`return nil, xerrors.Errorf("parse bool: %s", v.Value)`
`151`	`151`	`}`