fix: add mutex to MockAuditor export to prevent race (#5189)

kylecarbs · pull[bot] · commit 4e54ce2e3156 · 2023-12-12T21:53:32.000Z
See: https://github.com/coder/coder/actions/runs/3575201153/jobs/6011435900.
diff --git a/coderd/audit/audit.go b/coderd/audit/audit.go
@@ -2,6 +2,7 @@ package audit
 
 import (
 	"context"
+	"sync"
 
 	"github.com/coder/coder/coderd/database"
 )
@@ -30,10 +31,13 @@ func NewMock() *MockAuditor {
 }
 
 type MockAuditor struct {
+	mutex     sync.Mutex
 	AuditLogs []database.AuditLog
 }
 
 func (a *MockAuditor) Export(_ context.Context, alog database.AuditLog) error {
+	a.mutex.Lock()
+	defer a.mutex.Unlock()
 	a.AuditLogs = append(a.AuditLogs, alog)
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package audit`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
	`5`	`+ "sync"`
`5`	`6`
`6`	`7`	`"github.com/coder/coder/coderd/database"`
`7`	`8`	`)`
`@@ -30,10 +31,13 @@ func NewMock() *MockAuditor {`
`30`	`31`	`}`
`31`	`32`
`32`	`33`	`type MockAuditor struct {`
	`34`	`+ mutex sync.Mutex`
`33`	`35`	`AuditLogs []database.AuditLog`
`34`	`36`	`}`
`35`	`37`
`36`	`38`	`func (a *MockAuditor) Export(_ context.Context, alog database.AuditLog) error {`
	`39`	`+ a.mutex.Lock()`
	`40`	`+ defer a.mutex.Unlock()`
`37`	`41`	`a.AuditLogs = append(a.AuditLogs, alog)`
`38`	`42`	`return nil`
`39`	`43`	`}`