always return slive

f0ssel · f0ssel · commit 4e95a9964974 · 2022-09-16T18:46:00.000Z
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -812,10 +812,10 @@ func (api *API) convertWorkspaceBuild(
 	}
 
 	resources := resourcesByJobID[job.ID]
-	apiResources := []codersdk.WorkspaceResource{}
+	apiResources := make([]codersdk.WorkspaceResource, 0)
 	for _, resource := range resources {
 		agents := agentsByResourceID[resource.ID]
-		apiAgents := []codersdk.WorkspaceAgent{}
+		apiAgents := make([]codersdk.WorkspaceAgent, 0)
 		for _, agent := range agents {
 			apps := appsByAgentID[agent.ID]
 			apiAgent, err := convertWorkspaceAgent(api.DERPMap, api.TailnetCoordinator, agent, convertApps(apps), api.AgentInactiveDisconnectTimeout)
@@ -824,7 +824,7 @@ func (api *API) convertWorkspaceBuild(
 			}
 			apiAgents = append(apiAgents, apiAgent)
 		}
-		metadata := metadataByResourceID[resource.ID]
+		metadata := append(make([]database.WorkspaceResourceMetadatum, 0), metadataByResourceID[resource.ID]...)
 		apiResources = append(apiResources, convertWorkspaceResource(resource, apiAgents, metadata))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -812,10 +812,10 @@ func (api *API) convertWorkspaceBuild(`
`812`	`812`	`}`
`813`	`813`
`814`	`814`	`resources := resourcesByJobID[job.ID]`
`815`		`- apiResources := []codersdk.WorkspaceResource{}`
	`815`	`+ apiResources := make([]codersdk.WorkspaceResource, 0)`
`816`	`816`	`for _, resource := range resources {`
`817`	`817`	`agents := agentsByResourceID[resource.ID]`
`818`		`- apiAgents := []codersdk.WorkspaceAgent{}`
	`818`	`+ apiAgents := make([]codersdk.WorkspaceAgent, 0)`
`819`	`819`	`for _, agent := range agents {`
`820`	`820`	`apps := appsByAgentID[agent.ID]`
`821`	`821`	`apiAgent, err := convertWorkspaceAgent(api.DERPMap, api.TailnetCoordinator, agent, convertApps(apps), api.AgentInactiveDisconnectTimeout)`
`@@ -824,7 +824,7 @@ func (api *API) convertWorkspaceBuild(`
`824`	`824`	`}`
`825`	`825`	`apiAgents = append(apiAgents, apiAgent)`
`826`	`826`	`}`
`827`		`- metadata := metadataByResourceID[resource.ID]`
	`827`	`+ metadata := append(make([]database.WorkspaceResourceMetadatum, 0), metadataByResourceID[resource.ID]...)`
`828`	`828`	`apiResources = append(apiResources, convertWorkspaceResource(resource, apiAgents, metadata))`
`829`	`829`	`}`
`830`	`830`