fix: Check for a response body when dialing the Tailnet WebSocket (#4327)

kylecarbs · web-flow · commit 504cd462a738 · 2022-10-04T19:46:59.000-05:00
There was a panic in this code that caused it to fail on error!
diff --git a/codersdk/workspaceagents.go b/codersdk/workspaceagents.go
@@ -387,7 +387,7 @@ func (c *Client) DialWorkspaceAgentTailnet(ctx context.Context, logger slog.Logg
 				CompressionMode: websocket.CompressionDisabled,
 			})
 			if isFirst {
-				if err != nil && res.StatusCode == http.StatusConflict {
+				if res != nil && res.StatusCode == http.StatusConflict {
 					first <- readBodyAsError(res)
 					return
 				}

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,7 @@ func (c *Client) DialWorkspaceAgentTailnet(ctx context.Context, logger slog.Logg`
`387`	`387`	`CompressionMode: websocket.CompressionDisabled,`
`388`	`388`	`})`
`389`	`389`	`if isFirst {`
`390`		`- if err != nil && res.StatusCode == http.StatusConflict {`
	`390`	`+ if res != nil && res.StatusCode == http.StatusConflict {`
`391`	`391`	`first <- readBodyAsError(res)`
`392`	`392`	`return`
`393`	`393`	`}`