refactor: CR's fixes

evgeniy-scherbina · evgeniy-scherbina · commit 50bd9b46a3b3 · 2025-05-20T13:50:16.000Z
diff --git a/coderd/database/migrations/000328_prebuild_failure_limit_notification.up.sql b/coderd/database/migrations/000328_prebuild_failure_limit_notification.up.sql
@@ -2,9 +2,9 @@ INSERT INTO notification_templates
 (id, name, title_template, body_template, "group", actions)
 VALUES ('414d9331-c1fc-4761-b40c-d1f4702279eb',
 		'Prebuild Failure Limit Reached',
-		E'There is a problem creating prebuilt workspaces for the preset',
+		E'There is a problem creating prebuilt workspaces',
 		$$
-The number of failed prebuilds has reached the hard limit for template **{{ .Labels.template }}** and preset **{{ .Labels.preset }}**.
+The number of failed prebuild attempts has reached the hard limit for template **{{ .Labels.template }}** and preset **{{ .Labels.preset }}**.
 
 To resume prebuilds, fix the underlying issue and upload a new template version.
 $$,
diff --git a/coderd/notifications/testdata/rendered-templates/smtp/PrebuildFailureLimitReached.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/PrebuildFailureLimitReached.html.golden
@@ -1,6 +1,6 @@
 From: system@coder.com
 To: bobby@coder.com
-Subject: There is a problem creating prebuilt workspaces for the preset
+Subject: There is a problem creating prebuilt workspaces
 Message-Id: 02ee4935-73be-4fa1-a290-ff9999026b13@blush-whale-48
 Date: Fri, 11 Oct 2024 09:03:06 +0000
 Content-Type: multipart/alternative;  boundary=bbe61b741255b6098bb6b3c1f41b885773df633cb18d2a3002b68e4bc9c4
@@ -12,8 +12,8 @@ Content-Type: text/plain; charset=UTF-8
 
 Hi Bobby,
 
-The number of failed prebuilds has reached the hard limit for template dock=
-er and preset particle-accelerator.
+The number of failed prebuild attempts has reached the hard limit for templ=
+ate docker and preset particle-accelerator.
 
 To resume prebuilds, fix the underlying issue and upload a new template ver=
 sion.
@@ -35,8 +35,7 @@ Content-Type: text/html; charset=UTF-8
     <meta charset=3D"UTF-8" />
     <meta name=3D"viewport" content=3D"width=3Ddevice-width, initial-scale=
 =3D1.0" />
-    <title>There is a problem creating prebuilt workspaces for the preset</=
-title>
+    <title>There is a problem creating prebuilt workspaces</title>
   </head>
   <body style=3D"margin: 0; padding: 0; font-family: -apple-system, system-=
 ui, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarel=
@@ -51,13 +50,13 @@ er Logo" style=3D"height: 40px;" />
       </div>
       <h1 style=3D"text-align: center; font-size: 24px; font-weight: 400; m=
 argin: 8px 0 32px; line-height: 1.5;">
-        There is a problem creating prebuilt workspaces for the preset
+        There is a problem creating prebuilt workspaces
       </h1>
       <div style=3D"line-height: 1.5;">
         <p>Hi Bobby,</p>
-        <p>The number of failed prebuilds has reached the hard limit for te=
-mplate <strong>docker</strong> and preset <strong>particle-accelerator</str=
-ong>.</p>
+        <p>The number of failed prebuild attempts has reached the hard limi=
+t for template <strong>docker</strong> and preset <strong>particle-accelera=
+tor</strong>.</p>
 
 <p>To resume prebuilds, fix the underlying issue and upload a new template =
 version.</p>
diff --git a/coderd/notifications/testdata/rendered-templates/webhook/PrebuildFailureLimitReached.json.golden b/coderd/notifications/testdata/rendered-templates/webhook/PrebuildFailureLimitReached.json.golden
@@ -28,8 +28,8 @@
     "data": {},
     "targets": null
   },
-  "title": "There is a problem creating prebuilt workspaces for the preset",
-  "title_markdown": "There is a problem creating prebuilt workspaces for the preset",
-  "body": "The number of failed prebuilds has reached the hard limit for template docker and preset particle-accelerator.\n\nTo resume prebuilds, fix the underlying issue and upload a new template version.",
-  "body_markdown": "\nThe number of failed prebuilds has reached the hard limit for template **docker** and preset **particle-accelerator**.\n\nTo resume prebuilds, fix the underlying issue and upload a new template version.\n"
+  "title": "There is a problem creating prebuilt workspaces",
+  "title_markdown": "There is a problem creating prebuilt workspaces",
+  "body": "The number of failed prebuild attempts has reached the hard limit for template docker and preset particle-accelerator.\n\nTo resume prebuilds, fix the underlying issue and upload a new template version.",
+  "body_markdown": "\nThe number of failed prebuild attempts has reached the hard limit for template **docker** and preset **particle-accelerator**.\n\nTo resume prebuilds, fix the underlying issue and upload a new template version.\n"
 }
