count 0 vs -1

Emyrk · Emyrk · commit 515edf1e73ee · 2023-07-25T14:45:35.000-04:00
diff --git a/coderd/users.go b/coderd/users.go
@@ -253,7 +253,7 @@ func (api *API) GetUsers(rw http.ResponseWriter, r *http.Request) ([]database.Us
 	// GetUsers does not return ErrNoRows because it uses a window function to get the count.
 	// So we need to check if the userRows is empty and return an empty array if so.
 	if len(userRows) == 0 {
-		return []database.User{}, -1, true
+		return []database.User{}, 0, true
 	}
 
 	users := database.ConvertUserRows(userRows)
diff --git a/coderd/users_test.go b/coderd/users_test.go
@@ -1439,7 +1439,7 @@ func TestGetUsersPagination(t *testing.T) {
 	})
 	require.NoError(t, err)
 	require.Len(t, res.Users, 0)
-	require.Equal(t, res.Count, -1)
+	require.Equal(t, res.Count, 0)
 }
 
 func TestPostTokens(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,7 @@ func (api API) GetUsers(rw http.ResponseWriter, r http.Request) ([]database.Us`
`253`	`253`	`// GetUsers does not return ErrNoRows because it uses a window function to get the count.`
`254`	`254`	`// So we need to check if the userRows is empty and return an empty array if so.`
`255`	`255`	`if len(userRows) == 0 {`
`256`		`- return []database.User{}, -1, true`
	`256`	`+ return []database.User{}, 0, true`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`users := database.ConvertUserRows(userRows)`
Original file line number	Diff line number	Diff line change
`@@ -1439,7 +1439,7 @@ func TestGetUsersPagination(t *testing.T) {`
`1439`	`1439`	`})`
`1440`	`1440`	`require.NoError(t, err)`
`1441`	`1441`	`require.Len(t, res.Users, 0)`
`1442`		`- require.Equal(t, res.Count, -1)`
	`1442`	`+ require.Equal(t, res.Count, 0)`
`1443`	`1443`	`}`
`1444`	`1444`
`1445`	`1445`	`func TestPostTokens(t *testing.T) {`