Skip to content

Commit 52899fb

Browse files
aslilacaslilac
committed
remove react-helmet-async
1 parent 49c0b7e commit 52899fb

File tree

95 files changed

+155
-382
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

95 files changed

+155
-382
lines changed

‎site/.storybook/preview.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import {
2626
} from "@mui/material/styles";
2727
import { DecoratorHelpers } from "@storybook/addon-themes";
2828
import isChromatic from "chromatic/isChromatic";
29-
import React, { StrictMode } from "react";
29+
import { StrictMode } from "react";
3030
import { HelmetProvider } from "react-helmet-async";
3131
import { QueryClient, QueryClientProvider, parseQueryArgs } from "react-query";
3232
import { withRouter } from "storybook-addon-remix-react-router";

‎site/biome.jsonc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
"useButtonType": { "level": "off" },
1919
"useSemanticElements": { "level": "off" }
2020
},
21+
"correctness": {
22+
"noUnusedImports": "error"
23+
},
2124
"style": {
2225
"noNonNullAssertion": { "level": "off" },
2326
"noParameterAssign": { "level": "off" },

‎site/e2e/playwright.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { execSync } from "node:child_process";
2-
import * as path from "node:path";
32
import { defineConfig } from "@playwright/test";
43
import {
54
coderMain,

‎site/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
"react-confetti": "6.1.0",
9696
"react-date-range": "1.4.0",
9797
"react-dom": "19.0.0",
98-
"react-helmet-async": "2.0.5",
9998
"react-markdown": "9.0.1",
10099
"react-query": "npm:@tanstack/react-query@4.35.3",
101100
"react-router": "7.0.2",

‎site/src/@types/storybook.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import * as _storybook_types from "@storybook/react";
21
import type {
32
DeploymentValues,
43
Experiments,

‎site/src/api/queries/users.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import type {
99
UpdateUserProfileRequest,
1010
User,
1111
UsersRequest,
12-
ValidateUserPasswordRequest,
1312
} from "api/typesGenerated";
1413
import {
1514
type MetadataState,

‎site/src/components/ErrorBoundary/RuntimeErrorState.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { Loader } from "components/Loader/Loader";
99
import { Margins } from "components/Margins/Margins";
1010
import { Stack } from "components/Stack/Stack";
1111
import { type FC, useEffect, useState } from "react";
12-
import { Helmet } from "react-helmet-async";
1312
import { getStaticBuildInfo } from "utils/buildInfo";
1413

1514
const fetchDynamicallyImportedModuleError =
@@ -48,9 +47,8 @@ export const RuntimeErrorState: FC<RuntimeErrorStateProps> = ({ error }) => {
4847

4948
return (
5049
<>
51-
<Helmet>
52-
<title>Something went wrong...</title>
53-
</Helmet>
50+
<title>Something went wrong...</title>
51+
5452
{checkingError ? (
5553
<Loader fullscreen />
5654
) : (

‎site/src/components/Paywall/Paywall.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import Link from "@mui/material/Link";
55
import { PremiumBadge } from "components/Badges/Badges";
66
import { Stack } from "components/Stack/Stack";
77
import type { FC, ReactNode } from "react";
8-
import { docs } from "utils/docs";
98

109
export interface PaywallProps {
1110
message: string;

‎site/src/components/Paywall/PopoverPaywall.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import Link from "@mui/material/Link";
55
import { PremiumBadge } from "components/Badges/Badges";
66
import { Stack } from "components/Stack/Stack";
77
import type { FC, ReactNode } from "react";
8-
import { docs } from "utils/docs";
98

109
export interface PopoverPaywallProps {
1110
message: string;

‎site/src/pages/AuditPage/AuditPage.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { useDashboard } from "modules/dashboard/useDashboard";
77
import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
88
import { useOrganizationsFilterMenu } from "modules/tableFiltering/options";
99
import type { FC } from "react";
10-
import { Helmet } from "react-helmet-async";
1110
import { useSearchParams } from "react-router";
1211
import { pageTitle } from "utils/page";
1312
import { useActionFilterMenu, useResourceTypeFilterMenu } from "./AuditFilter";
@@ -69,9 +68,7 @@ const AuditPage: FC = () => {
6968

7069
return (
7170
<>
72-
<Helmet>
73-
<title>{pageTitle("Audit")}</title>
74-
</Helmet>
71+
<title>{pageTitle("Audit")}</title>
7572

7673
<AuditPageView
7774
auditLogs={auditsQuery.data?.audit_logs}

‎site/src/pages/CliAuthPage/CliAuthPage.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { apiKey } from "api/queries/users";
22
import type { FC } from "react";
3-
import { Helmet } from "react-helmet-async";
43
import { useQuery } from "react-query";
54
import { pageTitle } from "utils/page";
65
import { CliAuthPageView } from "./CliAuthPageView";
@@ -10,9 +9,8 @@ export const CliAuthenticationPage: FC = () => {
109

1110
return (
1211
<>
13-
<Helmet>
14-
<title>{pageTitle("CLI Auth")}</title>
15-
</Helmet>
12+
<title>{pageTitle("CLI Auth")}</title>
13+
1614
<CliAuthPageView sessionToken={data?.key} />
1715
</>
1816
);

‎site/src/pages/CreateTemplateGalleryPage/CreateTemplateGalleryPage.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { templateExamples } from "api/queries/templates";
22
import type { TemplateExample } from "api/typesGenerated";
33
import type { FC } from "react";
4-
import { Helmet } from "react-helmet-async";
54
import { useQuery } from "react-query";
65
import { pageTitle } from "utils/page";
76
import { getTemplatesByTag } from "utils/starterTemplates";
@@ -16,9 +15,8 @@ const CreateTemplatesGalleryPage: FC = () => {
1615

1716
return (
1817
<>
19-
<Helmet>
20-
<title>{pageTitle("Create a Template")}</title>
21-
</Helmet>
18+
<title>{pageTitle("Create a Template")}</title>
19+
2220
<CreateTemplateGalleryPageView
2321
error={templateExamplesQuery.error}
2422
starterTemplatesByTag={starterTemplatesByTag}

‎site/src/pages/CreateTemplatePage/CreateTemplatePage.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import type { TemplateVersion } from "api/typesGenerated";
33
import { FullPageHorizontalForm } from "components/FullPageForm/FullPageHorizontalForm";
44
import { linkToTemplate, useLinks } from "modules/navigation";
55
import { type FC, useRef, useState } from "react";
6-
import { Helmet } from "react-helmet-async";
76
import { useMutation } from "react-query";
87
import { useNavigate, useSearchParams } from "react-router";
98
import { pageTitle } from "utils/page";
@@ -46,9 +45,7 @@ const CreateTemplatePage: FC = () => {
4645

4746
return (
4847
<>
49-
<Helmet>
50-
<title>{pageTitle("Create Template")}</title>
51-
</Helmet>
48+
<title>{pageTitle("Create Template")}</title>
5249

5350
<FullPageHorizontalForm title="Create Template" onCancel={onCancel}>
5451
{searchParams.has("fromTemplate") ? (

‎site/src/pages/CreateTemplatePage/ImportStarterTemplateView.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
import { ErrorAlert } from "components/Alert/ErrorAlert";
88
import { Loader } from "components/Loader/Loader";
99
import { useDashboard } from "modules/dashboard/useDashboard";
10-
import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
1110
import type { FC } from "react";
1211
import { useQuery } from "react-query";
1312
import { useNavigate, useSearchParams } from "react-router";

‎site/src/pages/CreateTemplatePage/UploadTemplateView.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
} from "api/queries/templates";
88
import { displayError } from "components/GlobalSnackbar/utils";
99
import { useDashboard } from "modules/dashboard/useDashboard";
10-
import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
1110
import type { FC } from "react";
1211
import { useMutation, useQuery } from "react-query";
1312
import { useNavigate } from "react-router";

‎site/src/pages/CreateTokenPage/CreateTokenPage.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
77
import { Loader } from "components/Loader/Loader";
88
import { useFormik } from "formik";
99
import { type FC, useState } from "react";
10-
import { Helmet } from "react-helmet-async";
1110
import { useMutation, useQuery } from "react-query";
1211
import { useNavigate } from "react-router";
1312
import { pageTitle } from "utils/page";
@@ -89,9 +88,8 @@ export const CreateTokenPage: FC = () => {
8988

9089
return (
9190
<>
92-
<Helmet>
93-
<title>{pageTitle("Create Token")}</title>
94-
</Helmet>
91+
<title>{pageTitle("Create Token")}</title>
92+
9593
{tokenFetchFailed && <ErrorAlert error={tokenFetchError} />}
9694
<FullPageHorizontalForm
9795
title="Create Token"

‎site/src/pages/CreateUserPage/CreateUserForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { FullPageForm } from "components/FullPageForm/FullPageForm";
99
import { PasswordField } from "components/PasswordField/PasswordField";
1010
import { Stack } from "components/Stack/Stack";
1111
import { type FormikContextType, useFormik } from "formik";
12-
import { type FC, useEffect } from "react";
12+
import type { FC } from "react";
1313
import {
1414
displayNameValidator,
1515
getFormHelpers,

‎site/src/pages/CreateUserPage/CreateUserPage.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import { authMethods, createUser } from "api/queries/users";
22
import { displaySuccess } from "components/GlobalSnackbar/utils";
33
import { Margins } from "components/Margins/Margins";
4-
import { useDebouncedFunction } from "hooks/debounce";
5-
import { type FC, useState } from "react";
6-
import { Helmet } from "react-helmet-async";
4+
import type { FC } from "react";
75
import { useMutation, useQuery, useQueryClient } from "react-query";
86
import { useNavigate } from "react-router";
97
import { pageTitle } from "utils/page";
@@ -21,9 +19,7 @@ export const CreateUserPage: FC = () => {
2119

2220
return (
2321
<Margins>
24-
<Helmet>
25-
<title>{pageTitle("Create User")}</title>
26-
</Helmet>
22+
<title>{pageTitle("Create User")}</title>
2723

2824
<CreateUserForm
2925
error={createUserMutation.error}

‎site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { useEffectEvent } from "hooks/hookPolyfills";
1818
import { useDashboard } from "modules/dashboard/useDashboard";
1919
import { generateWorkspaceName } from "modules/workspaces/generateWorkspaceName";
2020
import { type FC, useCallback, useEffect, useRef, useState } from "react";
21-
import { Helmet } from "react-helmet-async";
2221
import { useMutation, useQuery, useQueryClient } from "react-query";
2322
import { useNavigate, useParams, useSearchParams } from "react-router";
2423
import { pageTitle } from "utils/page";
@@ -176,9 +175,8 @@ const CreateWorkspacePage: FC = () => {
176175

177176
return (
178177
<>
179-
<Helmet>
180-
<title>{pageTitle(title)}</title>
181-
</Helmet>
178+
<title>{pageTitle(title)}</title>
179+
182180
{isLoadingFormData || isLoadingExternalAuth || autoCreateReady ? (
183181
<Loader />
184182
) : (

‎site/src/pages/DeploymentSettingsPage/AppearanceSettingsPage/AppearanceSettingsPage.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
55
import { useDashboard } from "modules/dashboard/useDashboard";
66
import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
77
import type { FC } from "react";
8-
import { Helmet } from "react-helmet-async";
98
import { useMutation, useQueryClient } from "react-query";
109
import { pageTitle } from "utils/page";
1110
import { AppearanceSettingsPageView } from "./AppearanceSettingsPageView";
@@ -38,9 +37,7 @@ const AppearanceSettingsPage: FC = () => {
3837

3938
return (
4039
<>
41-
<Helmet>
42-
<title>{pageTitle("Appearance Settings")}</title>
43-
</Helmet>
40+
<title>{pageTitle("Appearance Settings")}</title>
4441

4542
<AppearanceSettingsPageView
4643
appearance={appearance}

‎site/src/pages/DeploymentSettingsPage/ExternalAuthSettingsPage/ExternalAuthSettingsPage.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { Loader } from "components/Loader/Loader";
21
import { useDeploymentSettings } from "modules/management/DeploymentSettingsProvider";
32
import type { FC } from "react";
4-
import { Helmet } from "react-helmet-async";
53
import { pageTitle } from "utils/page";
64
import { ExternalAuthSettingsPageView } from "./ExternalAuthSettingsPageView";
75

@@ -10,9 +8,8 @@ const ExternalAuthSettingsPage: FC = () => {
108

119
return (
1210
<>
13-
<Helmet>
14-
<title>{pageTitle("External Authentication Settings")}</title>
15-
</Helmet>
11+
<title>{pageTitle("External Authentication Settings")}</title>
12+
1613
<ExternalAuthSettingsPageView config={deploymentConfig.config} />
1714
</>
1815
);

‎site/src/pages/DeploymentSettingsPage/GeneralSettingsPage/GeneralSettingsPage.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { availableExperiments, experiments } from "api/queries/experiments";
44
import { useEmbeddedMetadata } from "hooks/useEmbeddedMetadata";
55
import { useDeploymentSettings } from "modules/management/DeploymentSettingsProvider";
66
import type { FC } from "react";
7-
import { Helmet } from "react-helmet-async";
87
import { useQuery } from "react-query";
98
import { pageTitle } from "utils/page";
109
import { GeneralSettingsPageView } from "./GeneralSettingsPageView";
@@ -26,9 +25,8 @@ const GeneralSettingsPage: FC = () => {
2625

2726
return (
2827
<>
29-
<Helmet>
30-
<title>{pageTitle("General Settings")}</title>
31-
</Helmet>
28+
<title>{pageTitle("General Settings")}</title>
29+
3230
<GeneralSettingsPageView
3331
deploymentOptions={deploymentConfig.options}
3432
deploymentDAUs={deploymentDAUsQuery.data}

‎site/src/pages/DeploymentSettingsPage/IdpOrgSyncPage/IdpOrgSyncPage.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { SquareArrowOutUpRight } from "lucide-react";
1212
import { useDashboard } from "modules/dashboard/useDashboard";
1313
import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
1414
import { type FC, useEffect } from "react";
15-
import { Helmet } from "react-helmet-async";
1615
import { useMutation, useQuery, useQueryClient } from "react-query";
1716
import { docs } from "utils/docs";
1817
import { pageTitle } from "utils/page";
@@ -51,9 +50,7 @@ export const IdpOrgSyncPage: FC = () => {
5150

5251
return (
5352
<>
54-
<Helmet>
55-
<title>{pageTitle("Organization IdP Sync")}</title>
56-
</Helmet>
53+
<title>{pageTitle("Organization IdP Sync")}</title>
5754

5855
<div className="flex flex-col gap-12">
5956
<header className="flex flex-row items-baseline justify-between">

‎site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/AddNewLicensePage.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { API } from "api/api";
22
import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
33
import type { FC } from "react";
4-
import { Helmet } from "react-helmet-async";
54
import { useMutation } from "react-query";
65
import { useNavigate } from "react-router";
76
import { pageTitle } from "utils/page";
@@ -37,9 +36,7 @@ const AddNewLicensePage: FC = () => {
3736

3837
return (
3938
<>
40-
<Helmet>
41-
<title>{pageTitle("License Settings")}</title>
42-
</Helmet>
39+
<title>{pageTitle("License Settings")}</title>
4340

4441
<AddNewLicensePageView
4542
isSavingLicense={isCreating}

‎site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/LicensesSettingsPage.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { entitlements, refreshEntitlements } from "api/queries/entitlements";
44
import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
55
import { useEmbeddedMetadata } from "hooks/useEmbeddedMetadata";
66
import { type FC, useEffect, useState } from "react";
7-
import { Helmet } from "react-helmet-async";
87
import { useMutation, useQuery, useQueryClient } from "react-query";
98
import { useSearchParams } from "react-router";
109
import { pageTitle } from "utils/page";
@@ -68,9 +67,8 @@ const LicensesSettingsPage: FC = () => {
6867

6968
return (
7069
<>
71-
<Helmet>
72-
<title>{pageTitle("License Settings")}</title>
73-
</Helmet>
70+
<title>{pageTitle("License Settings")}</title>
71+
7472
<LicensesSettingsPageView
7573
showConfetti={confettiOn}
7674
isLoading={isLoading}

‎site/src/pages/DeploymentSettingsPage/NetworkSettingsPage/NetworkSettingsPage.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import { Loader } from "components/Loader/Loader";
21
import { useDeploymentSettings } from "modules/management/DeploymentSettingsProvider";
32
import type { FC } from "react";
4-
import { Helmet } from "react-helmet-async";
53
import { pageTitle } from "utils/page";
64
import { NetworkSettingsPageView } from "./NetworkSettingsPageView";
75

@@ -10,9 +8,8 @@ const NetworkSettingsPage: FC = () => {
108

119
return (
1210
<>
13-
<Helmet>
14-
<title>{pageTitle("Network Settings")}</title>
15-
</Helmet>
11+
<title>{pageTitle("Network Settings")}</title>
12+
1613
<NetworkSettingsPageView options={deploymentConfig.options} />
1714
</>
1815
);

0 commit comments

Comments
 (0)