fix: do not cache getAuthenticatedUser call

Kira-Pilot · Kira-Pilot · commit 52b9b72e3dbe · 2023-10-19T15:47:42.000Z
diff --git a/site/index.html b/site/index.html
@@ -17,7 +17,6 @@
   <meta property="og:type" content="website" />
   <meta property="csrf-token" content="{{ .CSRF.Token }}" />
   <meta property="build-info" content="{{ .BuildInfo }}" />
-  <meta property="user" content="{{ .User }}" />
   <meta property="entitlements" content="{{ .Entitlements }}" />
   <meta property="appearance" content="{{ .Appearance }}" />
   <meta property="experiments" content="{{ .Experiments }}" />
diff --git a/site/src/api/queries/users.ts b/site/src/api/queries/users.ts
@@ -5,10 +5,8 @@ import {
   GetUsersResponse,
   UpdateUserPasswordRequest,
   UpdateUserProfileRequest,
-  User,
   UsersRequest,
 } from "api/typesGenerated";
-import { getMetadataAsJSON } from "utils/metadata";
 import { getAuthorizationKey } from "./authCheck";
 
 export const users = (req: UsersRequest): UseQueryOptions<GetUsersResponse> => {
@@ -89,21 +87,11 @@ export const authMethods = () => {
   };
 };
 
-const initialMeData = getMetadataAsJSON<User>("user");
-const meKey = ["me"] as const;
-
-export const me = (queryClient: QueryClient) => {
+export const me = () => {
   return {
-    queryKey: meKey,
-    queryFn: async () => {
-      const cachedData = queryClient.getQueryData(meKey);
-      if (cachedData === undefined && initialMeData !== undefined) {
-        return initialMeData;
-      }
-
-      return API.getAuthenticatedUser();
-    },
-  } satisfies UseQueryOptions<User>;
+    queryKey: ["me"],
+    queryFn: async () => API.getAuthenticatedUser(),
+  };
 };
 
 export const hasFirstUser = () => {
diff --git a/site/src/components/AuthProvider/AuthProvider.tsx b/site/src/components/AuthProvider/AuthProvider.tsx
@@ -46,7 +46,7 @@ const AuthContext = createContext<AuthContextValue | undefined>(undefined);
 
 export const AuthProvider: FC<PropsWithChildren> = ({ children }) => {
   const queryClient = useQueryClient();
-  const meOptions = me(queryClient);
+  const meOptions = me();
 
   const userQuery = useQuery(meOptions);
   const authMethodsQuery = useQuery(authMethods());
