fix: cli: avoid calling t.FailNow in non-test-main goroutine

johnstcn · johnstcn · commit 53417bb09aec · 2022-05-23T13:24:03.000+01:00
diff --git a/cli/userlist_test.go b/cli/userlist_test.go
@@ -16,15 +16,13 @@ func TestUserList(t *testing.T) {
 	coderdtest.CreateFirstUser(t, client)
 	cmd, root := clitest.New(t, "users", "list")
 	clitest.SetupConfig(t, client, root)
-	doneChan := make(chan struct{})
 	pty := ptytest.New(t)
 	cmd.SetIn(pty.Input())
 	cmd.SetOut(pty.Output())
+	errC := make(chan error)
 	go func() {
-		defer close(doneChan)
-		err := cmd.Execute()
-		require.NoError(t, err)
+		errC <- cmd.Execute()
 	}()
+	require.NoError(t, <-errC)
 	pty.ExpectMatch("coder.com")
-	<-doneChan
 }
