fix: ensure we are talking to coder on first user check

f0ssel · f0ssel · commit 534d0ea3060f · 2023-12-11T15:02:54.000Z
diff --git a/codersdk/users.go b/codersdk/users.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"io"
 	"net/http"
 	"strings"
 	"time"
@@ -190,7 +191,19 @@ func (c *Client) HasFirstUser(ctx context.Context) (bool, error) {
 		return false, err
 	}
 	defer res.Body.Close()
+
 	if res.StatusCode == http.StatusNotFound {
+		b, err := io.ReadAll(res.Body)
+		if err != nil {
+			return false, err
+		}
+		// ensure we are talking to coder and not
+		// some other service that returns 404
+		isCoder := strings.Contains(string(b), "initial user has not been created")
+		if !isCoder {
+			return false, xerrors.Errorf("unexpected response: %s", string(b))
+		}
+
 		return false, nil
 	}
 	if res.StatusCode != http.StatusOK {
