chore: autofill previous values from build on workspace settings

Emyrk · Emyrk · commit 53a57543dd11 · 2025-05-28T12:22:24.000-05:00
diff --git a/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageExperimental.tsx b/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageExperimental.tsx
@@ -39,6 +39,11 @@ const WorkspaceParametersPageExperimental: FC = () => {
 	const navigate = useNavigate();
 	const experimentalFormContext = useContext(ExperimentalFormContext);
 
+	const { data: originalParameters, isLoading: originalParametersLoading } = useQuery({
+		queryKey: ["workspace", "build", workspace.id, "parameters"],
+		queryFn: () => API.getWorkspaceBuildParameters(workspace.latest_build.id),
+	});
+
 	const [latestResponse, setLatestResponse] =
 		useState<DynamicParametersResponse | null>(null);
 	const wsResponseId = useRef<number>(-1);
@@ -149,6 +154,7 @@ const WorkspaceParametersPageExperimental: FC = () => {
 	const error = wsError || updateParameters.error;
 
 	if (
+		originalParametersLoading ||
 		!latestResponse ||
 		(ws.current && ws.current.readyState === WebSocket.CONNECTING)
 	) {
@@ -203,6 +209,7 @@ const WorkspaceParametersPageExperimental: FC = () => {
 				<WorkspaceParametersPageViewExperimental
 					workspace={workspace}
 					canChangeVersions={canChangeVersions}
+					originalParameters={originalParameters!}
 					parameters={sortedParams}
 					diagnostics={latestResponse.diagnostics}
 					isSubmitting={updateParameters.isPending}
diff --git a/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx b/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx
@@ -19,6 +19,7 @@ import { docs } from "utils/docs";
 
 type WorkspaceParametersPageViewExperimentalProps = {
 	workspace: Workspace;
+	originalParameters?: WorkspaceBuildParameter[];
 	parameters: PreviewParameter[];
 	diagnostics: PreviewParameter["diagnostics"];
 	canChangeVersions: boolean;
@@ -34,6 +35,7 @@ export const WorkspaceParametersPageViewExperimental: FC<
 	WorkspaceParametersPageViewExperimentalProps
 > = ({
 	workspace,
+	originalParameters,
 	parameters,
 	diagnostics,
 	canChangeVersions,
@@ -45,7 +47,10 @@ export const WorkspaceParametersPageViewExperimental: FC<
 	const form = useFormik({
 		onSubmit,
 		initialValues: {
-			rich_parameter_values: getInitialParameterValues(parameters),
+			rich_parameter_values: getInitialParameterValues(parameters, originalParameters!.map((p) => ({
+			...p,
+			source: "active_build",
+		}))),
 		},
 		validationSchema: useValidationSchemaForDynamicParameters(parameters),
 		enableReinitialize: false,
