fix(provisionerdserver): prevent NPE if no user link exists

johnstcn · johnstcn · commit 54beb671469d · 2024-10-30T11:10:04.000Z
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -2026,7 +2026,7 @@ func obtainOIDCAccessToken(ctx context.Context, db database.Store, oidcConfig pr
 		LoginType: database.LoginTypeOIDC,
 	})
 	if errors.Is(err, sql.ErrNoRows) {
-		err = nil
+		return nil, nil //nolint:nilnil
 	}
 	if err != nil {
 		return "", xerrors.Errorf("get owner oidc link: %w", err)

Original file line number	Diff line number	Diff line change
`@@ -2026,7 +2026,7 @@ func obtainOIDCAccessToken(ctx context.Context, db database.Store, oidcConfig pr`
`2026`	`2026`	`LoginType: database.LoginTypeOIDC,`
`2027`	`2027`	`})`
`2028`	`2028`	`if errors.Is(err, sql.ErrNoRows) {`
`2029`		`- err = nil`
	`2029`	`+ return nil, nil //nolint:nilnil`
`2030`	`2030`	`}`
`2031`	`2031`	`if err != nil {`
`2032`	`2032`	`return "", xerrors.Errorf("get owner oidc link: %w", err)`