Lock around close return

kylecarbs · kylecarbs · commit 5601b4d9da16 · 2022-02-18T17:02:18.000Z
diff --git a/provisionerd/provisionerd.go b/provisionerd/provisionerd.go
@@ -110,10 +110,13 @@ func (p *provisionerDaemon) connect(ctx context.Context) {
 			if errors.Is(err, context.Canceled) {
 				return
 			}
+			p.closeMutex.Lock()
 			if p.isClosed() {
+				p.closeMutex.Unlock()
 				return
 			}
 			p.opts.Logger.Warn(context.Background(), "failed to dial", slog.Error(err))
+			p.closeMutex.Unlock()
 			continue
 		}
 		p.opts.Logger.Debug(context.Background(), "connected")

Original file line number	Diff line number	Diff line change
`@@ -110,10 +110,13 @@ func (p *provisionerDaemon) connect(ctx context.Context) {`
`110`	`110`	`if errors.Is(err, context.Canceled) {`
`111`	`111`	`return`
`112`	`112`	`}`
	`113`	`+ p.closeMutex.Lock()`
`113`	`114`	`if p.isClosed() {`
	`115`	`+ p.closeMutex.Unlock()`
`114`	`116`	`return`
`115`	`117`	`}`
`116`	`118`	`p.opts.Logger.Warn(context.Background(), "failed to dial", slog.Error(err))`
	`119`	`+ p.closeMutex.Unlock()`
`117`	`120`	`continue`
`118`	`121`	`}`
`119`	`122`	`p.opts.Logger.Debug(context.Background(), "connected")`