feat(password): apply backend logic to all password set fields

defelmnq · defelmnq · commit 5838a6fcfebc · 2024-10-23T14:56:54.000Z
diff --git a/coderd/userauth.go b/coderd/userauth.go
@@ -444,7 +444,7 @@ func (api *API) postChangePasswordWithOneTimePasscode(rw http.ResponseWriter, r
 // @Param request body codersdk.ValidateUserPasswordRequest true "Validate user password request"
 // @Success 200 {object} codersdk.ValidateUserPasswordResponse
 // @Router /users/validate-password [post]
-func (api *API) validateUserPassword(rw http.ResponseWriter, r *http.Request) {
+func (*API) validateUserPassword(rw http.ResponseWriter, r *http.Request) {
 	var (
 		ctx   = r.Context()
 		valid = true
diff --git a/coderd/userpassword/userpassword_test.go b/coderd/userpassword/userpassword_test.go
@@ -26,6 +26,7 @@ func TestUserPasswordValidate(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			err := userpassword.Validate(tt.password)
@@ -39,6 +40,7 @@ func TestUserPasswordValidate(t *testing.T) {
 }
 
 func TestUserPasswordCompare(t *testing.T) {
+	t.Parallel()
 	tests := []struct {
 		name      string
 		hash      string
@@ -54,6 +56,7 @@ func TestUserPasswordCompare(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			if tt.hash == "" {

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ func TestUserPasswordValidate(t *testing.T) {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`for _, tt := range tests {`
	`29`	`+ tt := tt`
`29`	`30`	`t.Run(tt.name, func(t *testing.T) {`
`30`	`31`	`t.Parallel()`
`31`	`32`	`err := userpassword.Validate(tt.password)`
`@@ -39,6 +40,7 @@ func TestUserPasswordValidate(t *testing.T) {`
`39`	`40`	`}`
`40`	`41`
`41`	`42`	`func TestUserPasswordCompare(t *testing.T) {`
	`43`	`+ t.Parallel()`
`42`	`44`	`tests := []struct {`
`43`	`45`	`name string`
`44`	`46`	`hash string`
`@@ -54,6 +56,7 @@ func TestUserPasswordCompare(t *testing.T) {`
`54`	`56`	`}`
`55`	`57`
`56`	`58`	`for _, tt := range tests {`
	`59`	`+ tt := tt`
`57`	`60`	`t.Run(tt.name, func(t *testing.T) {`
`58`	`61`	`t.Parallel()`
`59`	`62`	`if tt.hash == "" {`