Update codersdk/users.go

Emyrk · aslilac · web-flow · commit 5926e7bd85d8 · 2024-08-07T11:04:27.000-05:00
Co-authored-by: Kayla Washburn-Love &lt;mckayla@hey.com&gt;
diff --git a/codersdk/users.go b/codersdk/users.go
@@ -309,10 +309,8 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {
 		return err
 	}
 	defer res.Body.Close()
-	// Check for both status codes, there was a release that changed this response
-	// to StatusNoContent. To be compatible with that, the second condition is
-	// included.
-	// The 'http.StatusNoContent' check can be removed in 2025
+	// Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response,
+	// which was a breaking change, and reverted in 2.14.1.
 	if res.StatusCode != http.StatusOK && res.StatusCode != http.StatusNoContent {
 		return ReadBodyAsError(res)
 	}

Original file line number	Diff line number	Diff line change
`@@ -309,10 +309,8 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {`
`309`	`309`	`return err`
`310`	`310`	`}`
`311`	`311`	`defer res.Body.Close()`
`312`		`- // Check for both status codes, there was a release that changed this response`
`313`		`- // to StatusNoContent. To be compatible with that, the second condition is`
`314`		`- // included.`
`315`		`- // The 'http.StatusNoContent' check can be removed in 2025`
	`312`	`+ // Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response,`
	`313`	`+ // which was a breaking change, and reverted in 2.14.1.`
`316`	`314`	`if res.StatusCode != http.StatusOK && res.StatusCode != http.StatusNoContent {`
`317`	`315`	`return ReadBodyAsError(res)`
`318`	`316`	`}`