test(coderd): Close metricscache and avoid background context

mafredri · mafredri · commit 599e8cef97df · 2023-06-13T13:32:17.000Z
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -298,6 +298,7 @@ func New(options *Options) *API {
 			DeploymentStats: options.AgentStatsRefreshInterval,
 		},
 	)
+	defer metricsCache.Close()
 
 	staticHandler := site.Handler(site.FS(), binFS, binHashes)
 	// Static file handler must be wrapped with HSTS handler if the
diff --git a/coderd/metricscache/metricscache_test.go b/coderd/metricscache/metricscache_test.go
@@ -435,6 +435,7 @@ func TestCache_DeploymentStats(t *testing.T) {
 	cache := metricscache.New(db, slogtest.Make(t, nil), metricscache.Intervals{
 		DeploymentStats: testutil.IntervalFast,
 	})
+	defer cache.Close()
 
 	_, err := db.InsertWorkspaceAgentStat(context.Background(), database.InsertWorkspaceAgentStatParams{
 		ID:                 uuid.New(),
diff --git a/coderd/workspaceapps/apptest/setup.go b/coderd/workspaceapps/apptest/setup.go
@@ -347,7 +347,7 @@ func createWorkspaceWithApps(t *testing.T, client *codersdk.Client, orgID uuid.U
 	primaryAppHost, err := client.AppHost(appHostCtx)
 	require.NoError(t, err)
 	if primaryAppHost.Host != "" {
-		manifest, err := agentClient.Manifest(context.Background())
+		manifest, err := agentClient.Manifest(appHostCtx)
 		require.NoError(t, err)
 		proxyURL := fmt.Sprintf(
 			"http://{{port}}--%s--%s--%s%s",

Original file line number	Diff line number	Diff line change
`@@ -298,6 +298,7 @@ func New(options Options) API {`
`298`	`298`	`DeploymentStats: options.AgentStatsRefreshInterval,`
`299`	`299`	`},`
`300`	`300`	`)`
	`301`	`+ defer metricsCache.Close()`
`301`	`302`
`302`	`303`	`staticHandler := site.Handler(site.FS(), binFS, binHashes)`
`303`	`304`	`// Static file handler must be wrapped with HSTS handler if the`