Apply suggestions from code review

snark87 · johnstcn · web-flow · commit 5a948fe79cad · 2024-04-18T14:13:46.000+02:00
add link to follow-up issue

Co-authored-by: Cian Johnston &lt;public@cianjohnston.ie&gt;
diff --git a/coderd/prometheusmetrics/prometheusmetrics.go b/coderd/prometheusmetrics/prometheusmetrics.go
@@ -80,6 +80,7 @@ func Workspaces(ctx context.Context, logger slog.Logger, registerer prometheus.R
 	}
 
 	// TODO: deprecated: remove in the future
+	// See: https://github.com/coder/coder/issues/12999
 	// Deprecation reason: gauge metrics should avoid suffix `_total``
 	workspaceLatestBuildTotalsDeprecated := prometheus.NewGaugeVec(prometheus.GaugeOpts{
 		Namespace: "coderd",
diff --git a/coderd/promoauth/oauth2.go b/coderd/promoauth/oauth2.go
@@ -102,6 +102,7 @@ func NewFactory(registry prometheus.Registerer) *Factory {
 				"resource",
 			}),
 			// TODO: deprecated: remove in the future
+			// See: https://github.com/coder/coder/issues/12999
 			// Deprecation reason: gauge metrics should avoid suffix `_total``
 			rateLimitDeprecated: factory.NewGaugeVec(prometheus.GaugeOpts{
 				Namespace: "coderd",

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ func Workspaces(ctx context.Context, logger slog.Logger, registerer prometheus.R`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`// TODO: deprecated: remove in the future`
	`83`	`+ // See: https://github.com/coder/coder/issues/12999`
`83`	`84`	// Deprecation reason: gauge metrics should avoid suffix `_total``
`84`	`85`	`workspaceLatestBuildTotalsDeprecated := prometheus.NewGaugeVec(prometheus.GaugeOpts{`
`85`	`86`	`Namespace: "coderd",`