connectionsTotal

mtojek · mtojek · commit 5ac27b75c371 · 2023-05-19T12:32:28.000+02:00
diff --git a/agent/agent.go b/agent/agent.go
@@ -998,7 +998,7 @@ func (a *agent) trackScriptLogs(ctx context.Context, reader io.Reader) (chan str
 
 func (a *agent) handleReconnectingPTY(ctx context.Context, logger slog.Logger, msg codersdk.WorkspaceAgentReconnectingPTYInit, conn net.Conn) (retErr error) {
 	defer conn.Close()
-	a.metrics.handler.Add(1)
+	a.metrics.connectionsTotal.Add(1)
 
 	a.connCountReconnectingPTY.Add(1)
 	defer a.connCountReconnectingPTY.Add(-1)
diff --git a/agent/metrics.go b/agent/metrics.go
@@ -14,7 +14,7 @@ import (
 )
 
 type agentMetrics struct {
-	handler            prometheus.Counter
+	connectionsTotal   prometheus.Counter
 	handlerError       prometheus.Counter
 	createCommandError prometheus.Counter
 	cmdStartError      prometheus.Counter
@@ -25,10 +25,10 @@ type agentMetrics struct {
 }
 
 func newAgentMetrics(registerer prometheus.Registerer) *agentMetrics {
-	handler := prometheus.NewCounter(prometheus.CounterOpts{
-		Namespace: "agent", Subsystem: "reconnecting_pty", Name: "handler",
+	connectionsTotal := prometheus.NewCounter(prometheus.CounterOpts{
+		Namespace: "agent", Subsystem: "reconnecting_pty", Name: "connections_total",
 	})
-	registerer.MustRegister(handler)
+	registerer.MustRegister(connectionsTotal)
 
 	handlerError := prometheus.NewCounter(prometheus.CounterOpts{
 		Namespace: "agent", Subsystem: "reconnecting_pty", Name: "error",
@@ -66,7 +66,7 @@ func newAgentMetrics(registerer prometheus.Registerer) *agentMetrics {
 	registerer.MustRegister(inputWriterError)
 
 	return &agentMetrics{
-		handler:            handler,
+		connectionsTotal:   connectionsTotal,
 		handlerError:       handlerError,
 		createCommandError: createCommandError,
 		cmdStartError:      cmdStartError,
